Closed
Bug 1179422
Opened 9 years ago
Closed 9 years ago
Expose third-party licenses via the settings
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: st3fan, Assigned: st3fan)
References
(Blocks 1 open bug)
Details
(Whiteboard: noteworthy)
Attachments
(2 files)
Show a page that contains all the licenses of projects that we depend on.
Assignee | ||
Comment 1•9 years ago
|
||
Work in progress. Adds a Credits & Acknowledgements item to the About section in the Settings. That opens a local web page that lists the licenses of all the dependencies we use.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Darrin, how do you want this to be exposed in the settings? I have a page in progress that is very much like about:license on Desktop. What should we call it in the settings?
Flags: needinfo?(dhenein)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8628393 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/664
Adds a Licenses item to the About section in the Settings. That will open a local (about:license) web page that shows the MPL 2.0 for the main project and also lists the licenses of all the dependencies we use.
Attachment #8628393 -
Flags: review?(sleroux)
Attachment #8628393 -
Flags: feedback?(dhenein)
Comment 4•9 years ago
|
||
Comment on attachment 8628393 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/664
LGTM - I also rebased it from master to update it with the latest build changes for Xcode 6.4
Attachment #8628393 -
Flags: review?(sleroux) → review+
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
NSLocalizedString note seems wrong, incorrect screenshot link maybe?
Flags: needinfo?(sarentz)
Assignee | ||
Comment 6•9 years ago
|
||
I am reopening this. Looks like this PR is not complete. It is missing changes that were made. I wonder if I forgot to push some. For example the string in settings should be "Licenses" .. and I reformatted the licenses to nicer looking HTML. Looking into what happened here.
Status: RESOLVED → REOPENED
Flags: needinfo?(sarentz)
Resolution: FIXED → ---
Assignee | ||
Comment 7•9 years ago
|
||
Screenshot for localizers
Assignee | ||
Comment 8•9 years ago
|
||
Followup fix https://github.com/mozilla/firefox-ios/commit/be54e69e3bf18d526b6dfb0c48f14bf9aa3b3c62
This includes the following changes:
* Changed "Licenses & Acknowledgements" to "Licenses"
* Updated the l10n comment and included a correct screenshot
* Updated Licenses.html to include mobile friendly copies
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(dhenein)
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: noteworthy
Updated•9 years ago
|
Attachment #8628393 -
Flags: feedback?(dhenein) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•