Expose third-party licenses via the settings

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

(Blocks: 1 bug)

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: noteworthy)

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Show a page that contains all the licenses of projects that we depend on.
(Assignee)

Comment 1

3 years ago
Created attachment 8628393 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/664

Work in progress. Adds a Credits & Acknowledgements item to the About section in the Settings. That opens a local web page that lists the licenses of all the dependencies we use.
(Assignee)

Updated

3 years ago
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Darrin, how do you want this to be exposed in the settings? I have a page in progress that is very much like about:license on Desktop. What should we call it in the settings?
Flags: needinfo?(dhenein)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8628393 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/664

Adds a Licenses item to the About section in the Settings. That will open a local (about:license) web page that shows the MPL 2.0 for the main project and also lists the licenses of all the dependencies we use.
Attachment #8628393 - Flags: review?(sleroux)
Attachment #8628393 - Flags: feedback?(dhenein)
Comment on attachment 8628393 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/664

LGTM - I also rebased it from master to update it with the latest build changes for Xcode 6.4
Attachment #8628393 - Flags: review?(sleroux) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
NSLocalizedString note seems wrong, incorrect screenshot link maybe?
Flags: needinfo?(sarentz)
(Assignee)

Comment 6

3 years ago
I am reopening this. Looks like this PR is not complete. It is missing changes that were made. I wonder if I forgot to push some. For example the string in settings should be "Licenses" .. and I reformatted the licenses to nicer looking HTML. Looking into what happened here.
Status: RESOLVED → REOPENED
Flags: needinfo?(sarentz)
Resolution: FIXED → ---
(Assignee)

Comment 7

3 years ago
Created attachment 8631051 [details]
Screenshot 2015-07-08 10.43.23.png

Screenshot for localizers
(Assignee)

Comment 8

3 years ago
Followup fix https://github.com/mozilla/firefox-ios/commit/be54e69e3bf18d526b6dfb0c48f14bf9aa3b3c62

This includes the following changes:

* Changed "Licenses & Acknowledgements" to "Licenses"
* Updated the l10n comment and included a correct screenshot
* Updated Licenses.html to include mobile friendly copies
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Flags: needinfo?(dhenein)
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Whiteboard: noteworthy
Attachment #8628393 - Flags: feedback?(dhenein) → feedback+
You need to log in before you can comment on or make changes to this bug.