1179462 - Review Board fooled by zero-diffs, spams bugzilla with needless (re-)reviews.

Status: RESOLVED DUPLICATE of bug 1169360

(MozReview Graveyard :: General, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

See Bug 1037389 comment 57.

If you look in Review board for that bug, all the commits are showing "Review request changed" (and blowing away r+'es) over, in most cases, zero changes, causing poor overview and bugzilla review notification and comment spam.

I'm updating the last patch or two. For all the other patches, the Review Board UX makes it appear like important updates need (re-)reviewing, when clicking on "Show changes" shows none.

Like here: https://reviewboard.mozilla.org/r/12031/#review10761
Which leads to: https://reviewboard.mozilla.org/r/12031/diff/2-3

Yes I'm still using mq (I know), and I may have hg pull'ed between commits, but it seems to me that Review Board could still be a lot smarter about this and not be fooled by zero-diffs.

I find myself hesitating to commit now because of the poor experience I'm inflicting on others. As a workaround I tried:

  hg push -c d806b0bd3ced review

to see if this would push just the last patch for me, but this created a new separate request, without diffs against earlier versions, which is not helpful.

Comment 1

[Gregory Szorc [:gps]]

The problem is known and tracked in a few places. Bug 1175166 is probably the most relevant to dupe against. It will be worked on shortly, as this is one of the top complaints of users.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I'm going to reopen this since it still happens for me when rebasing patches without changes.

Here's an example: https://reviewboard.mozilla.org/r/14429/diff/2-3/

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

See Bug 1189030 comment 10 and 11 for the spam.

Comment 4

[Mark Côté [:mcote]]

This is a separate problem, as it is not trivial to tell when the content has effectively not changed after a rebase.  See bug 1169360.  I'm going to re-resolve this as the original dup.