1179482 - crash in mozilla::MediaFormatReader::ReleaseMediaResources()

Status: RESOLVED DUPLICATE of bug 1180403

(Core :: Audio/Video, defect)

Description

[Jesper Hansen]

This bug was filed from the Socorro interface and is 
report bp-560df307-fcd3-401f-a03c-11b712150701.
=============================================================
More crashes: https://crash-stats.mozilla.com/report/list?product=Firefox&signature=mozilla%3A%3AMediaFormatReader%3A%3AReleaseMediaResources%28%29#tab-reports

I had https://www.youtube.com/watch?v=Pmr3XvaoVW4 running in the background, and once it hit around 1:10:00 to 1:20:00, then all the content tabs crashed.
I believe this could be related to some of the "out of sync" videos.
You may actually have to let the video run for the entire duration for it to crash :/

Comment 1

[Jim Mathies [:jimm]]

top crash on aurora with e10s and non-e10s.

Comment 2

[Robert Kaiser]

[Tracking Requested - why for this release]:
We should track for the release in general as it's a topcrash on both the browser and content process, with and without e10s, about 4% of overall crashes of both processes.

Comment 3

[User Dderss]

It should be noted that this crash is not background-specific. I just had it during foreground YouTube video playback.

Comment 4

[User Dderss]

Sorry for double post but I forgot to add specific YouTube video that crashes for me: https://youtu.be/CLcjvIQJns0

The interesting part is that I found that this specific video (in 1080p60 mode) crashes after couple of minutes of watching even after fresh restart:

1) https://crash-stats.mozilla.com/report/index/4db15b71-6b5a-4fe2-aa73-74c462150707 -- initial crash;

2) https://crash-stats.mozilla.com/report/index/67976bac-da32-48a7-8e17-b516a2150707 -- crash after fresh restart (due to previous crash).

I have watched couple of dozens of other videos earlier today (though they were regular 30 FPS, not 60 FPS playback as this one) and none of them has crashed FireFox.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41 as this was identified as a top crash in comment 2.

Comment 6

[User Dderss]

Description of this bug states that "Version: unspecified", but I just confirmed that YouTube video that crashes in Nightly in my case does not crash in release version 39, so the "Version" can be set to 41 and above.

Comment 7

[Robert Kaiser]

We're not using the Version field much, we use the status flags for marking which versions are affected.

Comment 8

[(Away)]

  1448 void MediaFormatReader::ReleaseMediaResources()
  1449 {
  1450   // Before freeing a video codec, all video buffers needed to be released
  1451   // even from graphics pipeline.
  1452   VideoFrameContainer* container = mDecoder->GetVideoFrameContainer();

mDecoder is null

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

I thought MediaFormatReader wasn't enabled on Nightly yet? So I'm surprised we have crash reports already.

We can probably just null-check mDecoder here.

Comment 10

[Jean-Yves Avenard [:jya]]

MediaFormatReader is the default for anything related to mp4.

But didn't I submitted a patch for exactly that problem last week?

Comment 11

[Jean-Yves Avenard [:jya]]

Ah yes: 
bug 1180403

Comment 12

[(Away)]

Since not everyone might be able to see the duplicate bug: I've confirmed that these stopped on nightly after bug 1180403 landed.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Setting status-firefox41 to "fixed" just like bug 1180403.