Closed
Bug 1179521
Opened 10 years ago
Closed 10 years ago
[EME] Replace test_eme_obs_notification.html with test for "mediakeys-request" notification
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
8.13 KB,
patch
|
mozbugz
:
review+
|
Details | Diff | Splinter Review |
In bug 1127416 we added an observer service notification when an EME media was loaded. We no longer use it. We should remove that.
We now use the "mediakeys-request" notification, dispatched by MediaKeySystemAccess::NotifyObservers(). We should have a unit test for that, and remove the old test, test_eme_obs_notification.html.
Assignee | ||
Comment 1•10 years ago
|
||
Add test_eme_request_notifications and remove test_eme_obs_notification.
We can't test all of the mediakeys-request notifications, as we'd need to be using Adobe EME, which we can't test on our Treeherder machines. We can test most of the cases though.
Attachment #8629116 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Keywords: checkin-needed
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Blocks: 1135013
You need to log in
before you can comment on or make changes to this bug.
Description
•