Intermittent apps/sms/test/marionette/drafts_test.js | Messages Drafts Messages Drafts Test Suite Thread draft is correctly saved

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: philor, Assigned: azasypkin)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MJS])

Attachments

(1 attachment)

No description provided.
I believe drafts tests became more stable in the scope of bug 1176976, so closing this one as FIXED.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I'm seeing a lot of drafs_test.js errors after I disable the retry logic in bug 1222215. For instance:

https://treeherder.mozilla.org/logviewer.html#?job_id=3173866&repo=gaia

I'm going to disable this test for now so that we can land bug 1222215.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [MJS]
Thanks Michael, will take a look.
Flags: needinfo?(azasypkin)
Okay, looks like all our troubles come from the fact that sometimes IndexedDB/asyncStorage is too slow on Treeherder that leads to a lot of different races in tests that based on asyncStorage - drafts and activities (likely the same culprit for bug 1233552 as well).

We need a reliable way to determine that view is visually-loaded when draft/drafts is/are loaded as well. Looking into this.
Assignee: nobody → azasypkin
Status: REOPENED → ASSIGNED
Flags: needinfo?(azasypkin)
Comment on attachment 8701510 [details] [review]
[gaia] azasypkin:bug-1179604-drafts-tests > mozilla-b2g:master

Hey Steve,

How does it look to you?

I was running Messages tests with this PR and disabled retry logic (see the link below, Gij1 includes all Messages integration tests) and it seems to be fine:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=029edcb905d7e476d6637840aec96ddf698a626d

Thanks!
Attachment #8701510 - Flags: feedback?(schung)
Comment on attachment 8701510 [details] [review]
[gaia] azasypkin:bug-1179604-drafts-tests > mozilla-b2g:master

This solution sounds fine, just wondering if there's other possible way to validate the accessibility of the send button(or the activity view).
Attachment #8701510 - Flags: feedback?(schung) → feedback+
(In reply to Steve Chung [:steveck] from comment #14)
> Comment on attachment 8701510 [details] [review]
> [gaia] azasypkin:bug-1179604-drafts-tests > mozilla-b2g:master
> 
> This solution sounds fine, just wondering if there's other possible way to
> validate the accessibility of the send button(or the activity view).

Thanks for feedback! Replied at GitHub, in short don't have good alternative idea right now, would be glad to get any pointer :)
Comment on attachment 8701510 [details] [review]
[gaia] azasypkin:bug-1179604-drafts-tests > mozilla-b2g:master

Hey Steve,

I've added unit tests as a separate commit, also please tell me if you have any good idea about "conversaion-view-is-totally-ready" flag! I can't really wrap up my mind to do anything easy and non-intrusive :/

But anyway maybe we can improve this later to get our tests back as soon as possible :)

Thanks!
Attachment #8701510 - Flags: review?(schung)
Comment on attachment 8701510 [details] [review]
[gaia] azasypkin:bug-1179604-drafts-tests > mozilla-b2g:master

Not sure whether we should consider compose input as a part of conversation view readiness. Current solution is fine for me and we can discuss more about the conversation view ready flag and the additional benefit for it. Thanks!
Attachment #8701510 - Flags: review?(schung) → review+
Thanks for review!

I've rebased PR on the latest master since bug 1222215 has been landed - Gij 16 that includes drafts looks good for 6 consequent runs. Gij 17 failed once for new_activity_test - but I'll look into it in the scope of 1235842.

Master: https://github.com/mozilla-b2g/gaia/commit/a6a054cc21f029dc8a330bfbf7d5438a93a7501a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.