Location bar bottom border shouldn't be displayed next to the autocomplete pop-up

VERIFIED FIXED in Firefox 40

Status

()

defect
P1
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: cornel_ionce, Assigned: dao)

Tracking

(Blocks 1 bug)

Trunk
Firefox 42
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox40 verified, firefox41 verified, firefox42 verified)

Details

Attachments

(1 attachment)

Reproducing on:
*42.0a1 Nightly, build ID: 20150701030207
*41.0a2 Aurora, build ID: 20150630004006

Based on the available mock-ups (http://people.mozilla.org/~shorlander/mockups/Windows-10/Windows-10.html), the awesome bar bottom margin should not be displayed when search results are visible, it should be overlapped by the autocomplete pop-up.

Screenshot of the issue: http://i.imgur.com/Wj4S5w1.png
Priority: -- → P1
Blocks: theme-win10
No longer blocks: windows-10
Summary: Awesome bar bottom margin is displayed in front of the autocomplete pop-up on Windows 10 → Location bar bottom border shouldn't be displayed next to the autocomplete pop-up
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8638903 - Flags: review?(jaws)
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff

Review of attachment 8638903 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8638903 - Flags: review?(jaws) → review+
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/30537bac6136
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff

Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: simple CSS fix, very low risk
[String/UUID change made/needed]: none
Attachment #8638903 - Flags: approval-mozilla-beta?
Attachment #8638903 - Flags: approval-mozilla-aurora?
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff

This change impacts all versions of Windows but jaws confirms that it's safe so let's get it into beta8 despite the fact that it only landed on m-c today. Beta+ Aurora+
Attachment #8638903 - Flags: approval-mozilla-beta?
Attachment #8638903 - Flags: approval-mozilla-beta+
Attachment #8638903 - Flags: approval-mozilla-aurora?
Attachment #8638903 - Flags: approval-mozilla-aurora+
Confirming the fix on Windows 10 64bit using:
- latest Aurora, build ID: 20150728004007
- Firefox 40.0b8, build ID: 20150727174134

Not closing this until the Nightly builds are available for verification.
Also confirming this on latest Nightly, build ID: 20150728030209.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.