Closed
Bug 1179752
Opened 10 years ago
Closed 10 years ago
Location bar bottom border shouldn't be displayed next to the autocomplete pop-up
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: noni, Assigned: dao)
References
Details
Attachments
(1 file)
1.26 KB,
patch
|
jaws
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Reproducing on:
*42.0a1 Nightly, build ID: 20150701030207
*41.0a2 Aurora, build ID: 20150630004006
Based on the available mock-ups (http://people.mozilla.org/~shorlander/mockups/Windows-10/Windows-10.html), the awesome bar bottom margin should not be displayed when search results are visible, it should be overlapped by the autocomplete pop-up.
Screenshot of the issue: http://i.imgur.com/Wj4S5w1.png
Updated•10 years ago
|
Priority: -- → P1
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Summary: Awesome bar bottom margin is displayed in front of the autocomplete pop-up on Windows 10 → Location bar bottom border shouldn't be displayed next to the autocomplete pop-up
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff
Review of attachment 8638903 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #8638903 -
Flags: review?(jaws) → review+
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify+
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff
Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: simple CSS fix, very low risk
[String/UUID change made/needed]: none
Attachment #8638903 -
Flags: approval-mozilla-beta?
Attachment #8638903 -
Flags: approval-mozilla-aurora?
Comment 6•10 years ago
|
||
Comment on attachment 8638903 [details] [diff] [review]
urlbar-autocomplete-border.diff
This change impacts all versions of Windows but jaws confirms that it's safe so let's get it into beta8 despite the fact that it only landed on m-c today. Beta+ Aurora+
Attachment #8638903 -
Flags: approval-mozilla-beta?
Attachment #8638903 -
Flags: approval-mozilla-beta+
Attachment #8638903 -
Flags: approval-mozilla-aurora?
Attachment #8638903 -
Flags: approval-mozilla-aurora+
Comment 7•10 years ago
|
||
status-firefox41:
--- → fixed
Comment 8•10 years ago
|
||
status-firefox40:
--- → fixed
Reporter | ||
Comment 9•10 years ago
|
||
Confirming the fix on Windows 10 64bit using:
- latest Aurora, build ID: 20150728004007
- Firefox 40.0b8, build ID: 20150727174134
Not closing this until the Nightly builds are available for verification.
Reporter | ||
Comment 10•10 years ago
|
||
Also confirming this on latest Nightly, build ID: 20150728030209.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•