Closed
Bug 1179846
Opened 9 years ago
Closed 9 years ago
Update Bookmark and Reading List status after UIActivityViewController runs
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: aaronmt, Assigned: st3fan)
Details
Attachments
(1 file)
1. Visit a site 2. Tap the Share button, tap Firefox 3. Add to Bookmark See bottom toolbar bookmark status not set
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sarentz
Assignee | ||
Updated•9 years ago
|
Summary: Using the Firefox Share method of adding to bookmarks on an active tab does not set the bookmark toolbar button status → Update Bookmark and Reading List status after UIActivityViewController runs
Assignee | ||
Comment 1•9 years ago
|
||
This patch catches the case where we do not update the status when the user adds the current page to either Bookmarks or Reading List. We don't really know if the user did, so we always update the state when the `UIActivityViewController` is dismissed with `completed` status. This patch also cleans up `updateNavigationToolbarStates()` a bit, which previously took both a `Browser` and a `WKWebView`. I don't think that made sense because the `webView ` was always `browser.webView`.
Attachment #8633479 -
Flags: review?(etoop)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8633479 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/731 LGTM
Attachment #8633479 -
Flags: review?(etoop) → review+
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•