Closed Bug 1180104 Opened 10 years ago Closed 7 years ago

Building without MOZ_ANDROID_MLS_STUMBLER set fails

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected)

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: fabrice, Unassigned)

Details

Because we try to build the robocop test at http://mxr.mozilla.org/mozilla-central/source/mobile/android/tests/browser/robocop/robocop.ini#193 Quickly looking I could not find a way to disable the test based on MOZ_ANDROID_MLS_STUMBLER value...
I don't think any test harness supports fine grain filtering based on build flags. Generally, we make the test pass immediately without doing things. But that won't work, since the test may reference code that isn't compiled ... ... and we don't support conditional test compilation yet. This looks like moving the build/mobile/robocop/Makefile.in invocations to explicit .java lists (better to move to moz.build with explicit Java file lists) and then making the list conditional. I don't think we want this until the moz.build file is in mobile/android/tests/browser/robocop -- otherwise, there's spooky action at a distance in the build system. See Bug 938659 and the discussion in there. This isn't hard, but it's not a priority for me.
Component: General → Build Config & IDE Support
https://searchfox.org/mozilla-central/source/mobile/android/moz.configure#78 can no longer be set, so this is no longer valid.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Firefox for Android → Firefox Build System
You need to log in before you can comment on or make changes to this bug.