1180184 - Template strings are slow because the JITs don't support JSOP_TOSTRING

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

According to http://kpdecker.github.io/six-speed/, our template strings are 865x slower than the non-template-string alternative.

The problem is that JSOP_TOSTRING is only implemented in the interpreter.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Could we make intrinsic_ToString/MToString work with all value types?  Because that would be the obvious thing to do in Ion if it were made to work.

Baseline could probably just do a vmcall to ToString, right?

Comment 2

[Tom S [:evilpie]]

Attachment: baseline-tostring

I haven't looked into implementing this for Ion yet, but at least this should get baseline support going.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8632225 [details] [diff] [review]
baseline-tostring

Review of attachment 8632225 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Want to file a follow-up bug for Ion, if you close this one?

I was wondering about using an IC, but considering template strings aren't used much (yet) this is fine.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37ad44083b99

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/37ad44083b99