Closed Bug 1180288 Opened 5 years ago Closed 4 years ago

Use native filepickers for Graphene

Categories

(Firefox OS Graveyard :: Runtime, defect)

Unspecified
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
FxOS-S11 (13Nov)
Tracking Status
firefox45 --- fixed

People

(Reporter: bbondy, Assigned: bbondy)

Details

(Whiteboard: graphene-larch)

Attachments

(1 file)

Currently `<input type="file">` does not work on graphene due to the b2g file picker implementation using a web activities and device storage API to get files.  We should use the native file pickers in widget instead when MOZ_GRAPHENE is defined.
Attached patch filepicker.diffSplinter Review
Uploaded with graphene on OSX :)
Assignee: nobody → netzen
Attachment #8629489 - Flags: review?(fabrice)
Whiteboard: graphene-larch
Attachment #8629489 - Flags: review?(fabrice) → review+
Larch was merged to mozilla-central in bug 1204965, but this was not included due to not having a review from a DOM peer. Please have a DOM peer review if this is still needed as it touches code in the dom directory.
Flags: needinfo?(netzen)
Attachment #8629489 - Flags: review?(khuey)
Flags: needinfo?(netzen)
Comment on attachment 8629489 [details] [diff] [review]
filepicker.diff

Review of attachment 8629489 [details] [diff] [review]:
-----------------------------------------------------------------

I admit to having no idea what this is ... but ok ...
Attachment #8629489 - Flags: review?(khuey) → review+
Thanks for the second pass, Graphene is just a runtime based on b2g for browser.html and Horizon (VR)
Since it's been a while I re-verified that on Graphene filepickers only work with this patch.
https://hg.mozilla.org/mozilla-central/rev/0a4373d0c1d5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in before you can comment on or make changes to this bug.