1180288 - Use native filepickers for Graphene

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Brian R. Bondy [:bbondy]]

Currently `<input type="file">` does not work on graphene due to the b2g file picker implementation using a web activities and device storage API to get files.  We should use the native file pickers in widget instead when MOZ_GRAPHENE is defined.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: filepicker.diff

Uploaded with graphene on OSX :)

Comment 2

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/larch/rev/e8cad3f8d298

Comment 3

[Brian R. Bondy [:bbondy]]

Relanded with proper patch headers:
http://hg.mozilla.org/projects/larch/rev/80f39a3a53a9
http://hg.mozilla.org/projects/larch/rev/7623f490f057

Comment 4

[Kevin Grandon :kgrandon]

Larch was merged to mozilla-central in bug 1204965, but this was not included due to not having a review from a DOM peer. Please have a DOM peer review if this is still needed as it touches code in the dom directory.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8629489 [details] [diff] [review]
filepicker.diff

Review of attachment 8629489 [details] [diff] [review]:
-----------------------------------------------------------------

I admit to having no idea what this is ... but ok ...

Comment 6

[Brian R. Bondy [:bbondy]]

Thanks for the second pass, Graphene is just a runtime based on b2g for browser.html and Horizon (VR)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a4373d0c1d5

Comment 8

[Brian R. Bondy [:bbondy]]

Since it's been a while I re-verified that on Graphene filepickers only work with this patch.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a4373d0c1d5

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a4373d0c1d5