Closed Bug 118033 Opened 23 years ago Closed 23 years ago

remove useless assertion

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bstell, Assigned: bstell)

Details

Attachments

(1 file, 1 obsolete file)

Patch for both GTK+ and Xlib gfx
1.10 KB, patch
bstell
: review+
blizzard
: superreview+
Details | Diff | Splinter Review
this assertion is not meaning full: ###!!! ASSERTION: failed to get converter type: 'mDocConverterType!=nsnull', file /builds/trunk/mozilla/gfx/src/gtk/nsFontMetricsGTK.cpp, line 4114 ###!!! Break: at file /builds/trunk/mozilla/gfx/src/gtk/nsFontMetricsGTK.cpp,
Attached patch patch; remove assertion (obsolete) — — Splinter Review
bstell: Are you sure we do not need that assertion anymore ? I am getting tons of them while browsing www.thai.net (we still miss thai support in GTK+ and Xlib...) ...
Attachment #63446 - Attachment is obsolete: true
I am sure we do not need this assertion. It only says we do not have a converter for every font encoding. Obviously it would be nice to have every possible converter but missing the converter does not make this section of code fail. r=bstell@ix.netcom.com for attachment 63589 [details] [diff] [review]
Attachment #63589 - Flags: review+
Comment on attachment 63589 [details] [diff] [review] Patch for both GTK+ and Xlib gfx r/sr=blizzard
Attachment #63589 - Flags: superreview+
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Changed QA contact to brian.
QA Contact: teruko → bstell
marking this verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: