1180533 - Disable BackgroundHangMonitor on gonk

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[[:fabrice] Fabrice Desré]

This is causing too many wakeups and hurts battery life, and we have people doogfooding on non-released channels so we need to force it off on gonk.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: background-hang-monitor.patch

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 8629717 [details] [diff] [review]
background-hang-monitor.patch

Review of attachment 8629717 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/moz.build
@@ +59,5 @@
>      '/tools/profiler',
>  ]
>  
>  # BHR disabled for Release builds because of bug 965392.
>  # BHR disabled for debug builds because of bug 979069.

add another comment linking to this bug

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/ce4ca807b6a7

Comment 4

[Gabriele Svelto [:gsvelto]]

Just my 2p: it might have been worth adding a comment as to why we're disabling the monitor on b2g.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce4ca807b6a7

Comment 6

[Gabriele Svelto [:gsvelto]]

I know it's late but nominating for v2.2+ nevertheless because the fix is trivial and the problem quite severe when it manifests itself.

Comment 7

[Josh Cheng [:josh]]

Thanks Fabrice,
Do you mind raise the uplift request for 2.2? Thanks!

Comment 8

[Josh Cheng [:josh]]

Also NI 2.2r EPM Wesley as this also required for 2.2r.

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Yes. Would like to pick 2.2+ blockers to 2.2r as well.

Comment 10

[[:fabrice] Fabrice Desré]

Comment on attachment 8629717 [details] [diff] [review]
background-hang-monitor.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: battery life suffers.
Testing completed: 
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8629717 [details] [diff] [review]
background-hang-monitor.patch

We're doing v2.2->v2.2r merges still.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a68ed6cfd8c

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/4a68ed6cfd8c