Closed Bug 1180558 Opened 10 years ago Closed 10 years ago

[RTL] About page doesn't support the RTL direction exactly.

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: manel, Assigned: manel)

Details

(Keywords: rtl, Whiteboard: [kb=1792290] )

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20150513191138 Steps to reproduce: *get the last version of bedrock *open the bedrock project *activate the virtual venv *run *Go through about page with arabic language Actual results: the article in the left (ltr direction) and the video with the red title in the right. Expected results: the video should be in the left and the article with the red title in the right.
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(craigcook.bugz)
Depends on: 1166055
Thanks for filing bugs! I'm working on a site-wide better RTL handing in Bug 1166055. There are many pages requiring an optimization but this specific page can be prioritized. I'll send a GitHub pull request hopefully this week.
(In reply to Kohei Yoshino [:kohei] from comment #1) > Thanks for filing bugs! I'm working on a site-wide better RTL handing in Bug > 1166055. There are many pages requiring an optimization but this specific > page can be prioritized. I'll send a GitHub pull request hopefully this week. Great Kohei, I can help too in the RTl handing in CSS
This is my PR needs review
Attachment #8629767 - Flags: review?(kohei.yoshino)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(craigcook.bugz)
Oh mermi, sorry I couldn't recognize your real name ;-) Please go ahead with your PR; my PR is an site-wide overhaul that may take longer to bake.
Assignee: nobody → manel.rhaiem92
Component: Bedrock → Pages & Content
Whiteboard: [kb=1792290]
Status: NEW → ASSIGNED
Version: Development/Staging → Production
No longer depends on: 1166055
Keywords: rtl
Attachment #8629767 - Flags: review?(kohei.yoshino)
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/109336eb60313bc0cf4d806782b85ac0669eff73 Merge pull request #3102 from mermi/bug-1180558-about-page-rtl Fix Bug 1180558, aligning video correctly fixes RTL
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: