Last Comment Bug 1180571 - remove the ability to search attachment data
: remove the ability to search attachment data
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: Search (show other bugs)
: Production
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
:
:
Mentors:
Depends on:
Blocks: 1160929
  Show dependency treegraph
 
Reported: 2015-07-05 21:35 PDT by Byron Jones ‹:glob›
Modified: 2015-07-31 18:21 PDT (History)
8 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
1180571_1.patch (6.41 KB, patch)
2015-07-05 23:50 PDT, Byron Jones ‹:glob›
dylan: review+
Details | Diff | Splinter Review

Description User image Byron Jones ‹:glob› 2015-07-05 21:35:52 PDT
once we move to s3 you'll no longer be able to search attachments by their content.  investigations on bug 1160929 indicate this is a largely unused feature so we're safe to remove it.
Comment 1 User image Byron Jones ‹:glob› 2015-07-05 23:50:29 PDT
Created attachment 8629806 [details] [diff] [review]
1180571_1.patch

- remove attach_data.thedata support from search and quicksearch
Comment 2 User image Dylan Hardison [:dylan] 2015-07-15 10:03:54 PDT
Comment on attachment 8629806 [details] [diff] [review]
1180571_1.patch

Review of attachment 8629806 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Comment 3 User image Byron Jones ‹:glob› 2015-07-16 22:01:33 PDT
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a124414..22d71ed  master -> master
Comment 4 User image Axel Hecht [:Pike] 2015-07-29 22:48:11 PDT
We haven't practically done this, but we always liked the idea to search for patches that affect l10n, i.e., the option to search for things affecting /locales/en-US/.

Use cases are reviewing patches on localizability problems before they land, or searching for patches with approval requests that slip in string changes.

Though, now with increasing usage of reviewboard, that's probably not a fail-safe path anyway.
Comment 5 User image Gregory Szorc [:gps] (away until 2017-03-20) 2015-07-31 18:21:00 PDT
Patches belong in version control, not Bugzilla attachments. Comment #4 is not a valid concern long term.

Note You need to log in before you can comment on or make changes to this bug.