Closed
Bug 1180571
Opened 10 years ago
Closed 10 years ago
remove the ability to search attachment data
Categories
(bugzilla.mozilla.org :: Search, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(1 file)
|
6.41 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
once we move to s3 you'll no longer be able to search attachments by their content. investigations on bug 1160929 indicate this is a largely unused feature so we're safe to remove it.
- remove attach_data.thedata support from search and quicksearch
Attachment #8629806 -
Flags: review?(dylan)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8629806 [details] [diff] [review]
1180571_1.patch
Review of attachment 8629806 [details] [diff] [review]:
-----------------------------------------------------------------
r=dylan
Attachment #8629806 -
Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
a124414..22d71ed master -> master
Status: NEW → RESOLVED
Closed: 10 years ago
Component: General → Search
Resolution: --- → FIXED
|
||
Comment 4•10 years ago
|
||
We haven't practically done this, but we always liked the idea to search for patches that affect l10n, i.e., the option to search for things affecting /locales/en-US/.
Use cases are reviewing patches on localizability problems before they land, or searching for patches with approval requests that slip in string changes.
Though, now with increasing usage of reviewboard, that's probably not a fail-safe path anyway.
|
||
Comment 5•10 years ago
|
||
Patches belong in version control, not Bugzilla attachments. Comment #4 is not a valid concern long term.
You need to log in
before you can comment on or make changes to this bug.
Description
•