The default bug view has changed. See this FAQ.

remove the ability to search attachment data

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Search
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
once we move to s3 you'll no longer be able to search attachments by their content.  investigations on bug 1160929 indicate this is a largely unused feature so we're safe to remove it.
(Assignee)

Comment 1

2 years ago
Created attachment 8629806 [details] [diff] [review]
1180571_1.patch

- remove attach_data.thedata support from search and quicksearch
Attachment #8629806 - Flags: review?(dylan)
Comment on attachment 8629806 [details] [diff] [review]
1180571_1.patch

Review of attachment 8629806 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8629806 - Flags: review?(dylan) → review+
(Assignee)

Comment 3

2 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a124414..22d71ed  master -> master
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Component: General → Search
Resolution: --- → FIXED

Comment 4

2 years ago
We haven't practically done this, but we always liked the idea to search for patches that affect l10n, i.e., the option to search for things affecting /locales/en-US/.

Use cases are reviewing patches on localizability problems before they land, or searching for patches with approval requests that slip in string changes.

Though, now with increasing usage of reviewboard, that's probably not a fail-safe path anyway.

Comment 5

2 years ago
Patches belong in version control, not Bugzilla attachments. Comment #4 is not a valid concern long term.
You need to log in before you can comment on or make changes to this bug.