1180605 - Gradle build fails because of missing dependency: spoon-runner:1.1.10-SNAPSHOT

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

The build process can't find dependency "com.squareup.spoon:spoon-runner:1.1.10-SNAPSHOT".

It's searching the dependency in jcenter.bintray.com, oss.sonatype.org and some local folders.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

jcenter only list spoon-runner 1.1.9 and lower:
* https://jcenter.bintray.com/com/squareup/spoon/spoon-runner/

sonatype lists 1.1.10 as final version and a 1.1.11-snapshot:
* https://oss.sonatype.org/#nexus-search;quick~spoon-runner

Maven central lists 1.1.10 and lower (only stable):
* http://search.maven.org/#search|gav|1|g%3A%22com.squareup.spoon%22%20AND%20a%3A%22spoon-runner%22

Looking at http://square.github.io/spoon/ it seems like 1.1.10 has been released and 1.1.11 is the new snapshot version.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

The dependency comes from our local spoon-gradle-plugin snapshot:
m/a/gradle/m2repo/com/stanfy/spoon/spoon-gradle-plugin/1.0.3-SNAPSHOT/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1180605 - spoon-gradle-plugin: Set spoon runner dependency to 1.1.10. r?mhaigh

Bug 1180605 - spoon-gradle-plugin: Set spoon runner dependency to 1.1.10. r?mhaigh

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Sebastian Kaspari from comment #3)
> Created attachment 8629858 [details]
> MozReview Request: Bug 1180605 - spoon-gradle-plugin: Set spoon runner
> dependency to 1.1.10. r?mhaigh
> 
> Bug 1180605 - spoon-gradle-plugin: Set spoon runner dependency to 1.1.10.
> r?mhaigh

This patch just sets the spoon-runner dependency from 1.1.10-SNAPSHOT to 1.1.10. NI nalexander because this fixes the build but maybe the release of 1.1.10 triggers more things we want to do.

Comment 5

[Martyn Haigh (:mhaigh)]

Comment on attachment 8629858 [details]
MozReview Request: Bug 1180605 - spoon-gradle-plugin: Set spoon runner dependency to 1.1.10. r?mhaigh

https://reviewboard.mozilla.org/r/12649/#review11113

This fixes the issue for me

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/e753a38af043

Comment 7

[Nick Alexander :nalexander [he/him]]

The question is, did my snapshot build include other changes?  /me goes to look.  Yes, this fixes the build dependency issue but breaks local testing, because I never upstreamed my local instrumentationArgs changes.  I'll submit the PR to https://github.com/stanfy/spoon-gradle-plugin/issues/60.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

As discussed on IRC: The spoon-gradle-plugin dependency in the tree is still untouched. Just a reference to a transitive dependency has been updated (1.1.10-SNAPSHOT -> 1.1.10).

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e753a38af043