1180624 - [Bugzilla Lite] Testing the Log in to Bugzilla Lite

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Manel Rhaiem [:manel]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150513191138

Steps to reproduce:

* get the spark version on you device "flame"
* get marionette client 
* write a test for the log in 


Actual results:

No test exist for the bugzilla lite app 


Expected results:

write test, and run it

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mermi:testBzlite > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8630457 [details] [review]
[gaia] mermi:testBzlite > mozilla-b2g:master

It's a great start! A little bit of clean up and we'll be ready for a review. Thanks :)

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8630457 [details] [review]
[gaia] mermi:testBzlite > mozilla-b2g:master

This is great! You quickly got the Page Object Pattern.
Just a couple of nits regarding the spelling of BugzillaLite and bugzilla_lite. But I wouldn't block on that.

One last thing, we need bug 1180651 to be resolved in order to make this test run on our continuous integration platform.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8630457 [details] [review]
[gaia] mermi:testBzlite > mozilla-b2g:master

Ooops, I forgot one thing in the review. Before merging the patch, could you create a file called manifest.ini in tests/python/gaia-ui-tests/gaiatest/tests/functional/bzlite/, and then add this:

> [parent:../manifest.ini]
> 
> [DEFAULT]
> spark = true
>
> [test_login_bzlite.py]

This will enable the test to be run in our Continuous Integration environment. Once you're done, please ask me for review again.

See example at https://github.com/mozilla-b2g/gaia/pull/30839/files#diff-50bb51f320d07ceff8f537b25ff35966R37

Comment 5

[Manel Rhaiem [:manel]]

Ok Johan I do it now

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] mermi:testLoginBzlite > mozilla-b2g:master

Comment 7

[Manel Rhaiem [:manel]]

Attachment: Testing the Log in to Bugzilla Lite

I did this new PR because I get some problems in the other one

Comment 8

[Manel Rhaiem [:manel]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> Comment on attachment 8630457 [details] [review]
> [gaia] mermi:testBzlite > mozilla-b2g:master
> 
> Ooops, I forgot one thing in the review. Before merging the patch, could you
> create a file called manifest.ini in
> tests/python/gaia-ui-tests/gaiatest/tests/functional/bzlite/, and then add
> this:
> 
> > [parent:../manifest.ini]
> > 
> > [DEFAULT]
> > spark = true
> >
> > [test_login_bzlite.py]
> 
> This will enable the test to be run in our Continuous Integration
> environment. Once you're done, please ask me for review again.
> 
> See example at
> https://github.com/mozilla-b2g/gaia/pull/30839/files#diff-
> 50bb51f320d07ceff8f537b25ff35966R37

Could you check the PR I added the file

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: Credentials PR

I thought updating the JsonConfigFile in Jenkins was enough. It seems like the non-bitbar jobs still relying on the git repo.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8641075 [details] [review]
Credentials PR

Code change looks fine, but I'd rather delete this file and exclusively use the file in Jenkins. For the common test variables this shouldn't be a problem.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8640053 [details] [review]
Testing the Log in to Bugzilla Lite

These were some minor changes. Carrying r+. The tests passed there http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-spark-319.mozilla-central.nightly.ui.functional.spark/61/console

The failure was because of a branch change, where the Treeherder Crendentials are not present.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Crap. Gaia is closed due to bug 1190860. We can't merge the PR at the moment.

Comment 13

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #11)
> The failure was because of a branch change, where the Treeherder
> Crendentials are not present.

After taking a closer look, it's not related to that. The issue was present even on master. I filed bug 1191248 to investigate it. 

I merged it in master at [1]. I made a mistake, I thought the PR was exactly the same as [2], where everything was fix to run on Jenkins. [3] showed I missed a nit. I pushed [4] which fixes the nits.

Here's a run showing that the test was executed correctly in master (modulo bug 1191248) [5]

[1] https://github.com/mozilla-b2g/gaia/commit/9ac6c431272b71fcfff3b46c39db8c76b6aa586a
[2] https://github.com/JohanLorenzo/gaia/commit/70f91b54bdae9da392f349781faf195c0b854afa
[3] http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-spark-319.mozilla-central.nightly.ui.functional.spark/67/console
[4] https://github.com/mozilla-b2g/gaia/commit/283e40fe02f5a91af4545c23ba90a678822686fb
[5] http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-spark-319.mozilla-central.nightly.ui.functional.spark/68/console