Closed
Bug 1180652
Opened 10 years ago
Closed 10 years ago
Teach Web Manifest Processor how to process moz_tile_color
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox42 | --- | affected |
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.82 KB,
patch
|
oyiptong
:
review+
|
Details | Diff | Splinter Review |
Teach Web Manifest Processor how to process `icons_background_color` member.
Proposed for standardization by: https://github.com/w3c/manifest/pull/387
Assignee | ||
Updated•10 years ago
|
Blocks: webmanifest
Assignee | ||
Comment 1•10 years ago
|
||
Replaces `background_color` per image for a more generic `icons_background_color` member. This avoids having authors having to repeat the background color of icons multiple times in a manifest. We may bring the more specific `background_color` if there is a strong need for it.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Summary: Teach Web Manifest Processor how to process icons_background_color → Teach Web Manifest Processor how to process moz_tile_color
Comment 3•10 years ago
|
||
Comment on attachment 8629939 [details] [diff] [review]
Processing icons_background_color steps and tests
Review of attachment 8629939 [details] [diff] [review]:
-----------------------------------------------------------------
I like that ManifestProcessor.jsm is the one that extracts the background color and not the ImageObjectProcessor
Attachment #8629939 -
Flags: review?(oyiptong) → review+
Updated•10 years ago
|
Flags: needinfo?(oyiptong)
Comment 4•10 years ago
|
||
Do you know why this hasn't been merged? Can I unbitrot and merge it?
Comment 5•10 years ago
|
||
Ah, looks like it has been removed from the spec: https://github.com/w3c/manifest/pull/387#issuecomment-120229879
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(oyiptong)
Resolution: --- → WONTFIX
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•