Closed
Bug 1180727
Opened 10 years ago
Closed 10 years ago
Use manifest URL instead of position to select activity handler on browser functional tests
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
For browser UI tests we are currently selecting the activity handler button based on the position it takes on the activity chooser. We can do better and select it by manifest URL instead. That way, even if anything changes wrt that activity, it will still work.
https://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/search/regions/browser.py#17
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Updated•10 years ago
|
Summary: Use manifest name instead of position → Use manifest URL instead of position to select activity handler on browser functional tests
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8629981 -
Flags: review?(jlorenzo)
|
||
Updated•10 years ago
|
Attachment #8629981 -
Flags: review+
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8629981 [details] [review]
[gaia] ferjm:bug1180727.browser.ui.test > mozilla-b2g:master
Passes on my device. I think it's better to rely on the manifest. However, we have multiple places where we pick activitiies. We need to deal with them too (for consistency). As this patch is needed for bug 1176712, we'll handle that in a follow up bug.
Thanks Fernando!
Attachment #8629981 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•