1180745 - Screenshot error logging is broken

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew Comminos [:acomminos]]

The string substitution code used in automationutils.py when mochitest screenshotting fails is incorrect (format string parameters are not in a tuple). This causes this error to occur when the test screenshotter fails on try:

15:03:56     INFO -  Exception in thread ProcessReader:
15:03:56     INFO -  Traceback (most recent call last):
15:03:56     INFO -    File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
15:03:56     INFO -      self.run()
15:03:56     INFO -    File "/usr/lib/python2.7/threading.py", line 504, in run
15:03:56     INFO -      self.__target(*self.__args, **self.__kwargs)
15:03:56     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozprocess/processhandler.py", line 920, in _read
15:03:56     INFO -      callback(line.rstrip())
15:03:56     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozprocess/processhandler.py", line 840, in __call__
15:03:56     INFO -      e(*args, **kwargs)
15:03:56     INFO -    File "/builds/slave/test/build/tests/mochitest/runtests.py", line 2373, in processOutputLine
15:03:56     INFO -      message = handler(message)
15:03:56     INFO -    File "/builds/slave/test/build/tests/mochitest/runtests.py", line 2517, in dumpScreenOnFail
15:03:56     INFO -      self.harness.dumpScreen(self.utilityPath)
15:03:56     INFO -    File "/builds/slave/test/build/tests/mochitest/runtests.py", line 1562, in dumpScreen
15:03:56     INFO -      dumpScreen(utilityPath)
15:03:56     INFO -    File "/builds/slave/test/build/tests/mochitest/automationutils.py", line 312, in dumpScreen
15:03:56     INFO -      utility[0], err.strerror)
15:03:56     INFO -  TypeError: not enough arguments for format string

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Fix logging test screenshotting errors.

Here's a patch that fixes the aforementioned string formatting issue. Thanks!

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8629995 [details] [diff] [review]
Fix logging test screenshotting errors.

Review of attachment 8629995 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc355133eba

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5fc355133eba