Closed Bug 1180756 Opened 5 years ago Closed 5 years ago

"Harness status: OK" + failing test when running "service-worker-csp-script.https.html" test

Categories

(Testing :: web-platform-tests, defect)

defect
Not set
normal

Tracking

(firefox42 affected, firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox42 --- affected
firefox44 --- fixed

People

(Reporter: noemi, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Checked with 7/6 master build

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/service-worker-csp-script.https.html|

Result:
* Harness status: OK
* Found 1 test
* 1 Fail:
** CSP test for script-src in ServiceWorkerGlobalScope	
*** assert_unreached: unregister and register should not fail: The expression cannot be converted to return the specified type. Reached unreachable code
unreached_rejection/<@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js?pipe=sub:42:7 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1387:1 Promise*service_worker_unregister_and_register@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js?pipe=sub:8:10 service_worker_test/<@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js?pipe=sub:146:14 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 promise_test@https://web-platform.test:8443/resources/testharness.js:520:25 service_worker_test@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js?pipe=sub:145:1 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/service-worker-csp-script.https.html:7:1 
* Traces: https://pastebin.mozilla.org/8838621
The same error that running "service-worker-csp-default.https.html" test
and "service-worker-csp-connect.https.html" test
Summary: "Harness status: OK" + failing test when running wpt "service-worker-csp-script.https.html" test → "Harness status: OK" + failing test when running "service-worker-csp-script.https.html" test
Component: DOM: Service Workers → web-platform-tests
Product: Core → Testing
See Also: → 1187951
Bobby, can you take a look at this test failure? At [1] jdm says: "service-worker-csp-script.https.html - something about script-src, but service-worker-csp-worker.py is missing"

[1]
https://etherpad.mozilla.org/blink-sw-tests
Flags: needinfo?(bobbyholley)
The test now times out, because it's expecting a CSP error to be thrown synchronously for the load of a script from the service worker, and we don't do that. Instead, we get an async failure here:

https://pastebin.mozilla.org/8847291

On a higher level though, I'm confused as to why we care about this. My impression was that we were explicitly punting on CSP for the worker itself, and that the spec there had yet to be worked out. Am I missing something?
Flags: needinfo?(bobbyholley) → needinfo?(overholt)
And apparently overholt is out - bkelly, can you comment?
Flags: needinfo?(overholt) → needinfo?(bkelly)
I agree.  I think we can leave this as expected TIMEOUT.

Slightly better, if we could make the script postMessage() back a failure to the document or something so we could FAIL immediately, that would be preferable.
Flags: needinfo?(bkelly)
I'm not actively working on this, but let's get it in the tree so that it
doesn't get lost.
Attachment #8668203 - Flags: review?(bkelly)
Attachment #8665133 - Attachment is obsolete: true
Attachment #8668203 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/9b6124d343e8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Hi,

just checked on m-c (5f16c6c2b969 revision) and the test, as expected (please see comment 5), times out.

Summary

Harness status: Timeout

Found 1 tests
1 Timeout
Details
Result	Test Name	Message
Timeout	CSP test for script-src in ServiceWorkerGlobalScope	Test timed out
Depends on: 1216858
You need to log in before you can comment on or make changes to this bug.