1180771 - When navigating to a page on the same domain, don't set the default icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Guillaume Marty [:gmarty]]

When the user navigate to a page located on the same domain than the previous one, there is no need to set the default icon. We can keep the current icon. But we still need to look for the best icon after the new page is loaded (it can have a different manifest or meta tags than the previous one).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1180771-When-navigating-to-a-page-on-the-same-domain-dont-set-the-default-icon > mozilla-b2g:master

Comment 2

[Guillaume Marty [:gmarty]]

Comment on attachment 8630041 [details] [review]
[gaia] gmarty:Bug-1180771-When-navigating-to-a-page-on-the-same-domain-dont-set-the-default-icon > mozilla-b2g:master

Ben, can you review this patch? It's a UX optimisation on the icon.

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8630041 [details] [review]
[gaia] gmarty:Bug-1180771-When-navigating-to-a-page-on-the-same-domain-dont-set-the-default-icon > mozilla-b2g:master

Hi Guillaume,

I know this is annoying at the moment and I know this is what we did for the prototype, but I'm not sure this is the right solution for the real implementation.

The reasons are:
1. It's possible to have multiple sites per domain with different icons (.e.g. google.com/calendar and google.com/maps) where the icon should change when you navigate between them.
2. I'd like to have a loading spinner displayed in place of the icon while a page is loading instead (see bug 1179908).

It's possible that we can optimise the implementation to try to prevent the icon being set again unnecessarily, but I think we need to actually check whether the icon URL has changed, not just the hostname of the document URL.

One exception to this is that if a manifest with a scope property and icon is provided, it is safe to assume that any URL within that scope has the same icon.

Comment 4

[Guillaume Marty [:gmarty]]

The point 1. is already covered by this patch. The icon is checked again after load, even if the page is on the same domain than the previous one.
I think it's in line with how the theme-color works. We don't reset to grey during page load and transition the colour from the previous to the new one.

Comment 5

[Guillaume Marty [:gmarty]]

I don't think this behaviour is incompatible with using a spinner in the icon. Even if we decide to go for the spinner, we can still reuse the icon from the previous page if on the same domain. Then change it again if it's different on the new page.

I think we should also consider the value of scope, as you suggested. Do you want me to update this patch accordingly?

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 8630041 [details] [review]
[gaia] gmarty:Bug-1180771-When-navigating-to-a-page-on-the-same-domain-dont-set-the-default-icon > mozilla-b2g:master

OK, this is an improvement on what is there right now.

r+ with nits on Github.

Thanks!

Comment 7

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/3df4a6a71ec462b284bff57402badce99f8c8091