Closed
Bug 1180824
Opened 9 years ago
Closed 9 years ago
Implement media playback events for browser-element / Graphene
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(2 files)
2.00 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
7.37 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Getting per frame media playback information would be useful for sound indicators. This bug is to implement the Graphene support.
Assignee | ||
Updated•9 years ago
|
Whiteboard: graphene-larch
Assignee | ||
Comment 1•9 years ago
|
||
This adds a new browser event for `mediaplaybackchange` (`mozbrowsermediaplaybackchange`). detail will be `active` or `inactive`. Useful for things like having a tab audio indicator.
Attachment #8630269 -
Flags: review?(fabrice)
Comment 2•9 years ago
|
||
Comment on attachment 8630269 [details] [diff] [review] media-events.diff Review of attachment 8630269 [details] [diff] [review]: ----------------------------------------------------------------- That looks good, but I'd like that to land on m-c instead of graphene. Which means that we need tests ;)
Attachment #8630269 -
Flags: review?(fabrice) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Please also indicate if feedback+ -> r+ with this. Thanks!
Attachment #8630998 -
Flags: review?(fabrice)
Updated•9 years ago
|
Attachment #8630998 -
Flags: review?(fabrice) → review+
Updated•9 years ago
|
Attachment #8630269 -
Flags: feedback+ → review+
Assignee | ||
Comment 5•9 years ago
|
||
Saw an issue on b2g emulator when running through try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=504ad61a6cb6 B2G ICS Emulator opt I think I just need to use special powers instead of setBookPref to get it to work there. Once I fix I'll carry forward the r+ as long as its trivial and land.
Assignee | ||
Comment 6•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/da847a11950e1a29529003f8add33c7f66d99da0 changeset: da847a11950e1a29529003f8add33c7f66d99da0 user: Brian R. Bondy <netzen@gmail.com> date: Fri Jul 10 20:30:01 2015 -0400 description: Bug 1180824 - Implement media playback events for browser-element / Graphene. r=fabrice url: https://hg.mozilla.org/integration/mozilla-inbound/rev/5876bda26a837196534fe5e10aabf4752a06d574 changeset: 5876bda26a837196534fe5e10aabf4752a06d574 user: Brian R. Bondy <netzen@gmail.com> date: Fri Jul 10 20:30:03 2015 -0400 description: Bug 1180824 - Tests for browser-element mozbrowsermediaplaybackchange event. r=fabrice
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da847a11950e https://hg.mozilla.org/mozilla-central/rev/5876bda26a83
You need to log in
before you can comment on or make changes to this bug.
Description
•