1180824 - Implement media playback events for browser-element / Graphene

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Brian R. Bondy [:bbondy]]

Getting per frame media playback information would be useful for sound indicators. This bug is to implement the Graphene support.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: media-events.diff

This adds a new browser event for `mediaplaybackchange` (`mozbrowsermediaplaybackchange`).

detail will be `active` or `inactive`.
Useful for things like having a tab audio indicator.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8630269 [details] [diff] [review]
media-events.diff

Review of attachment 8630269 [details] [diff] [review]:
-----------------------------------------------------------------

That looks good, but I'd like that to land on m-c instead of graphene. Which means that we need tests ;)

Comment 3

[Brian R. Bondy [:bbondy]]

Will do, thanks for the review.

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: media-change-tests.diff

Please also indicate if feedback+ -> r+ with this. Thanks!

Comment 5

[Brian R. Bondy [:bbondy]]

Saw an issue on b2g emulator when running through try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=504ad61a6cb6 B2G ICS Emulator opt

I think I just need to use special powers instead of setBookPref to get it to work there. 
Once I fix I'll carry forward the r+ as long as its trivial and land.

Comment 6

[Brian R. Bondy [:bbondy]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/da847a11950e1a29529003f8add33c7f66d99da0
changeset:  da847a11950e1a29529003f8add33c7f66d99da0
user:       Brian R. Bondy <[e-mail]>
date:       Fri Jul 10 20:30:01 2015 -0400
description:
Bug 1180824 - Implement media playback events for browser-element / Graphene. r=fabrice

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5876bda26a837196534fe5e10aabf4752a06d574
changeset:  5876bda26a837196534fe5e10aabf4752a06d574
user:       Brian R. Bondy <[e-mail]>
date:       Fri Jul 10 20:30:03 2015 -0400
description:
Bug 1180824 - Tests for browser-element mozbrowsermediaplaybackchange event. r=fabrice

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da847a11950e
https://hg.mozilla.org/mozilla-central/rev/5876bda26a83