Closed
Bug 1180887
Opened 11 years ago
Closed 11 years ago
Split test_request_context.html
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
|
7.48 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
27.58 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
This should help with the test stability issues that we have been seeing in this test on Android. Even though this doesn't strictly block shipping, I would like to figure this out before adding more stuff to that test...
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8630316 -
Flags: review?(amarchesini)
| Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8630317 -
Flags: review?(amarchesini)
Comment 3•11 years ago
|
||
Comment on attachment 8630316 [details] [diff] [review]
Part 1: Separate out the JS code inside test_request_context.html
Review of attachment 8630316 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/workers/test/serviceworkers/test_request_context.html
@@ +14,2 @@
> <iframe></iframe>
> +<script type="text/javascript">
remove this script tag. it's empty.
Attachment #8630316 -
Flags: review?(amarchesini) → review+
Updated•11 years ago
|
Attachment #8630317 -
Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/3e413dc0296b
https://hg.mozilla.org/mozilla-central/rev/72782726fd6f
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•