1180907 - Call Drawable.mutate before setting tint

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot from bug 1079182 (glass should be black)

We set tint at [1] but it affects the asset used in bug 1079182. As per the Drawable.mutate documentation [2]:

Make this drawable mutable. This operation cannot be reversed. A mutable drawable is guaranteed to not share its state with any other drawable. This is especially useful when you need to modify properties of drawables loaded from resources. By default, all drawables instances loaded from the same resource share a common state; if you modify the state of one instance, all the other instances will receive the same modification. Calling this method on a mutable Drawable will have no effect.

---
So we're mutating the shared Drawable.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/SearchEngineBar.java?rev=cdcfb0ec9848#179
[2]: http://developer.android.com/reference/android/graphics/drawable/Drawable.html#mutate%28%29

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

See http://android-developers.blogspot.com/2009/05/drawable-mutations.html for more.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1180907 - Mutate search label before tinting it. r=sebastian

Bug 1180907 - Mutate search label before tinting it. r=sebastian

If we don't mutate, we're tinting the shared Drawable state and other Drawables
using the same asset might also get tinted.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8630173 [details]
MozReview Request: Bug 1180907 - Mutate search label before tinting it. r=sebastian

https://reviewboard.mozilla.org/r/12691/#review11281

Ship It!

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Oh, this is good to know and easy to forget. :)

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/43e91e8a73317f69413c66d544a7ab0f90ec5129
changeset:  43e91e8a73317f69413c66d544a7ab0f90ec5129
user:       Michael Comella <[e-mail]>
date:       Mon Jul 06 14:42:22 2015 -0700
description:
Bug 1180907 - Mutate search label before tinting it. r=sebastian

If we don't mutate, we're tinting the shared Drawable state and other Drawables
using the same asset might also get tinted.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43e91e8a7331