1181161 - Handle more browser version patterns

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: BrowserCompat, defect)

Description

[John Whitlock [:jwhitlock]]

What problem would this feature solve?
======================================
On DOMMouseScroll [1], the KumaScript 
"{{ CompatGeckoMobile("0.9.7") }}" is used, and the importer raised an exception because 0.9.7 can't be converted to a float.

[1] https://developer.mozilla.org/en-US/docs/Web/Events/DOMMouseScroll

Who has this problem?
=====================
Staff contributors to MDN

How do you know that the users identified above have this problem?
==================================================================
See the import error for this page:

http://browsercompat.herokuapp.com/importer/868

How are the users identified above solving this problem now?
============================================================
The import can not continue after an exception.

Do you have any suggestions for solving the problem? Please explain in detail.
==============================================================================
The parser can be improved to handle "0.9.7", either treating it as a legitimate version number or adding it as an issue and continue parsing.

Is there anything else we should know?
======================================
0.9.7 appears to be an invalid Gecko engine version, so an issue is the right thing for this case.

Comment 1

[Jean-Yves Perrier [:teoli]]

Note that there are some cases where x.y.z is a valid version numbers. I remember some feature changes that happens in 1.0.z versions. Not many, but some.

I think assuming a version number can be stored in a float is neither valid, nor future proof.

Comment 2

[John Whitlock [:jwhitlock]]

This bug just covers the CompatGeckoMobile KumaScript tag [1].  It converts "0.9.6" into Firefox 0.0, which feels wrong.  The CompatGeckoDesktop KS tag [2] is more complicated, and translates this to "unknown version", which feels right.

The compact API doesn't include engine versions, so this will convert it to the "current" Firefox Mobile version [3], which we use when we don't know the exact version, and add a warning-level issue.

[1] https://developer.mozilla.org/en-US/docs/Template:CompatGeckoMobile
[2] https://developer.mozilla.org/en-US/docs/Template:CompatGeckoDesktop
[3] https://browsercompat.herokuapp.com/browse/versions/67

Comment 3

[John Whitlock [:jwhitlock]]

Firefox OS 1.0.1 also breaks this pattern.  The API field validation needs to allow it.

Comment 4

[John Whitlock [:jwhitlock]]

This was fixed on August 15th, 2015, with commit https://github.com/mdn/browsercompat/commit/5b7f8ce9db265107177d895f333070bd359a3244