1181182 - /whatsnew URL for Firefox 40 (Windows 10 users only)

Status: RESOLVED INVALID

(Release Engineering :: Release Requests, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

For RC40 (August 11th), we would like to redirect ONLY Windows 10 users to the /whatsnew URL.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

This should be easy to do in the update server, we just need to know how Firefox makes a request for updates on Windows 10. From wikipedia, this will be something like

https://aus4.mozilla.org/update/3/Firefox/.../release/Windows_NT%2010.0.xxxx%20%28x64%29/...

and we can key off the 'Windows_NT 10.0' part. If someone has Windows 10 on hand, and can confirm that it would be helpful. Just set app.update.log to true in about:config, restart firefox, Help > About, and look in the browser console.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

With the 10162 build I get this:

AUS:SVC Checker:checkForUpdates - sending request to: https://aus4.mozilla.org/update/3/Firefox/39.0/20150630154324/WINNT_x86-msvc/en-US/release/Windows_NT%2010.0.0.0%20(x64)/default/default/update.xml

So we'll be able to create a rule with OS Version set to 'Windows_NT 10.0', which will point at a release blob with whatsnew enabled. This is the same method we used for Pocket, except filtering on OS Version instead of locales.

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Just a quick checkin on this bug. Want to ensure we are still go to only send Windows 10 users to the 40 /whatsnew page. Non Windows 10 users will not get redirected.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Cory Price [:ckprice] from comment #3)
> Just a quick checkin on this bug. Want to ensure we are still go to only
> send Windows 10 users to the 40 /whatsnew page. Non Windows 10 users will
> not get redirected.

Yeah, we can do this pretty easily. We'll set-up rules on test channels for QE to verify the right behaviour before we ship.

Comment 5

[[e-mail] (:bhearsum)]

Given that bug 1179925 (and all previous what's new page bugs) are public, I'm opening this one up too.

Comment 6

[[e-mail] (:bhearsum)]

Corey, I see that work has begun to implement a fully client side pop-up for Windows 10 users over in bug 1185012. If that lands in Beta. I see that that's targeted at Firefox 41, so I _think_ that means that we still want to do this for Firefox 40, but there will be no need for a Windows 10 what's new page in 41 -- does that matche your understanding?

Comment 7

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Ben Hearsum [:bhearsum] from comment #6)
> so I _think_ that means that we still want to
> do this for Firefox 40, 

Yep, nothing changes for 40.

> but there will be no need for a Windows 10 what's
> new page in 41 -- does that matche your understanding?

If bug 1185012 lands in 41, we won't need a Windows 10 page in 41.

Thanks for checking in Ben.

Comment 8

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

:clarkbw - do we need to add a locale qualifier for the /whatsnew page? Or is it okay to show the message to all locales 'Firefox + Windows 10. Perfect Together'?

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Locale is already in the path I think - the update server will specify 
  https://www.mozilla.org/%LOCALE%/firefox/40.0/whatsnew/?oldversion=%OLD_VERSION%
where %LOCALE% is replaced with the application locale from the update request. Is that easy to use server side ?

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Cory Price [:ckprice] from comment #8)
> :clarkbw - do we need to add a locale qualifier for the /whatsnew page? Or
> is it okay to show the message to all locales 'Firefox + Windows 10. Perfect
> Together'?

As Nick said, the locale is already in the URL. I believe this URL is: https://www.mozilla.org/%LOCALE%/firefox/windows10/ according to attachment 8635493 [details] [diff]

Cory, do we have enough time for l10n on this new page?

Comment 11

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #10)
> As Nick said, the locale is already in the URL. I believe this URL is:
> https://www.mozilla.org/%LOCALE%/firefox/windows10/ according to attachment
> 8635493 [details] [diff] [review]

Hey Bryan, I believe you're mistaking this /whatsnew page for bug 1185012.

My question was focused on /whatsnew 40 which just displays the 'Firefox + Windows 10' message and nothing about Cortana or anything else. It looks like we're good to show this page for all Windows 10 Firefox users and not restrict by locale?

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Cory Price [:ckprice] from comment #11)
> (In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #10)
> Hey Bryan, I believe you're mistaking this /whatsnew page for bug 1185012.

Oh sorry, too many URLs.

> My question was focused on /whatsnew 40 which just displays the 'Firefox +
> Windows 10' message and nothing about Cortana or anything else. It looks
> like we're good to show this page for all Windows 10 Firefox users and not
> restrict by locale?

I believe so but I want to check with Winston on this.

Comment 13

[Winston Bowden]

No need to restrict by locale.

Comment 14

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Based on the unexpected uplift of bug 1185012 to Firefox 40, we will be replacing the /whatsnew page with a Welcome page (bug 1186485).

There will be NO /whatsnew page for Firefox 40.