1181217 - Annotate MOZ_CRASH so that socorro can search for them

Status: RESOLVED DUPLICATE of bug 1183355

(Core :: MFBT, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Getting a MOZ_CRASH in the wild may suggest we're hitting situations we should not be.  In some cases, where it's an OOM, we should be OK, but in some cases we're not, and we want to find those problems before we hit the high enough crash count to notice them.

If this information is in the annotations, we would also be able to process all the "relevant" MOZ_CRASH crashes, instead of whatever statistical percentage we end up processing today.

This may very well turn into a meta bug.

Comment 1

[Robert Kaiser]

I think it's best to leave this bug for adding the additional annotation, and we can add further steps dependent on this one as needed.

IMHO, we should add an annotation into that macro, with a key of "MozCrash" or so and a value of the comment that is handed to that MOZ_CRASH macro.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I think that's where we should end up.  I'm going to suggest we start by creating a separate one, something like MOZ_CRASH_REPORT that would do this annotation, use it in a few places and sort out the issues, get socorro/supersearch up to speed.  Once we're happy with it, we can have it become MOZ_CRASH.

Comment 3

[(no longer active)]

This is really the same as bug 1183355.