1181253 - Make the sync datatype selections into two columns

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Ryan Feeley [:rfeeley]]

Instead of a list of 6 checkboxes at 100% width, make the list 3 items long in two columnns 50% width.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Screen Shot 2015-07-07 at 5.34.14 PM.png

Waiting on rfeeley approval for this!

Comment 2

[Edouard Oger [:eoger]]

Attachment: bug-1181253.patch

The patch used in the previous screenshot

Comment 3

[Ryan Feeley [:rfeeley]]

I think 50% was a bad idea. Sorry! Maybe % is a bad idea because of localization. Is there a way to just put padding or space between the columns? Not much, just 10% width?

Comment 4

[Edouard Oger [:eoger]]

Attachment: Screen Shot 2015-07-08 at 3.23.49 PM.png

How about this?

Comment 5

[Edouard Oger [:eoger]]

Attachment: bug-1181253.patch

Patch used for above screenshot.

Comment 6

[Ryan Feeley [:rfeeley]]

Great!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5191567d4542

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5191567d4542

Comment 9

[Forhad Hossain]

I have reproduced this bug in nightly 42.0a1(2015-07-07)(Build ID:20150707030206) with Comment 0's instruction on Linux lite 32bit.

Bug is fixed now on latest beta 42.0b3(Build ID:20151001142456)

Mozilla/5.0 (X11; Linux i686; rv:42.0) Gecko/20100101 Firefox/42.0


[testday-20151002]

Comment 10

[Rezaul Huque Nayeem]

Reproduced the bug in firefox nightly 42.0a1 (2015-07-07) with windows 7 (64 bit)

Verified as fixed with latest firefox beta 42.0b8 (Build ID: 20151019161651)

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0 

As it is also verified on Linux (Comment 9), Marking it as verified!