Closed
Bug 1181348
Opened 10 years ago
Closed 10 years ago
ARM64: Fix debug tests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
A bunch of debug tests are failing because one of the offsets we save is asserted to be to the first instruction of a PC mapping. We were trying to avoid some constant pool logic, so it was placed later. This records the offset where it needs to go.
The code for ToggleCall() already looks like it handles this case, but it has an unreadable hardcoded constant instruction branch, so I'm not sure what it's doing. It will probably have to be rewritten when something actually uses that path. Right now it's untested, so there's no point to fixing it up.
Attachment #8630749 -
Flags: review?(kvijayan)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sstangl
|
||
Updated•10 years ago
|
Attachment #8630749 -
Flags: review?(kvijayan) → review+
|
||
Comment 2•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•