1181382 - Building with clang tip fails: "declaration conflicts with target of using declaration already in scope" (Promise)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

In file included from /Users/jruderman/builds/mozilla-central-asan-opt/dom/base/Unified_cpp_dom_base1.cpp:137:
In file included from /Users/jruderman/trees/mozilla-central/dom/base/Navigator.cpp:42:
../../dist/include/mozilla/dom/MobileMessageManager.h:17:1: error: declaration conflicts with target of using declaration already in scope
class Promise;
^
../../dist/include/mozilla/dom/Promise.h:73:7: note: target of using declaration
class Promise : public nsISupports,
      ^
/Users/jruderman/trees/mozilla-central/dom/base/DOMRequest.cpp:22:21: note: using declaration
using mozilla::dom::Promise;
                    ^

Comment 1

[Jesse Ruderman]

Attachment: patch suggested by heycam

This seems to fix it.

The offending line was added in https://hg.mozilla.org/mozilla-central/rev/e7150eb09fa3

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8630811 [details] [diff] [review]
patch suggested by heycam

Review of attachment 8630811 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the catch.

Comment 3

[Samael Wang [:freesamael] (away for now)]

Comment on attachment 8630811 [details] [diff] [review]
patch suggested by heycam

Review of attachment 8630811 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ae1ee6a67e7

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1ae1ee6a67e7