Closed Bug 1181428 Opened 9 years ago Closed 9 years ago

Only persist deviceIds after user has granted gUM permission

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(4 files)

MozReview Request: Bug 1181428 - move code to reuse test for active gum or persistent permission
40 bytes, text/x-review-board-request
jib
: review+
Details
MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt
40 bytes, text/x-review-board-request
jib
: review+
Details
MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt
40 bytes, text/x-review-board-request
jib
: review+
Details
MozReview Request: Bug 1181428 - defer persisting until gUM succeeds or persistent permission
40 bytes, text/x-review-board-request
jib
: review+
Details
Bug 1181428 - move code to reuse test for active gum or persistent permission
Attachment #8632216 - Flags: review?(martin.thomson)
Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys
Attachment #8632217 - Flags: review?(martin.thomson)
Bug 1181428 - plumb origin through to success path
Attachment #8632218 - Flags: review?(martin.thomson)
Bug 1181428 - defer persisting until gUM succeeds or persistent permission
Attachment #8632219 - Flags: review?(martin.thomson)
Depends on: 1046245
backlog: --- → webRTC+
Rank: 15
Priority: -- → P1
Attachment #8632216 - Flags: review?(martin.thomson) → review+
Comment on attachment 8632216 [details] MozReview Request: Bug 1181428 - move code to reuse test for active gum or persistent permission https://reviewboard.mozilla.org/r/13019/#review11649 I would have split the new function in two, but it's fine as is.
Comment on attachment 8632217 [details] MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt https://reviewboard.mozilla.org/r/13021/#review11651 ::: dom/media/systemservices/MediaParent.cpp:119 (Diff revision 1) > - GetOriginKey(const nsACString& aOrigin, nsCString& result) > + GetOriginKey(const nsACString& aOrigin, nsCString& result, bool persist) Though I agree with Jeff regarding aFoo arguments, you should probably be consistent.
Attachment #8632217 - Flags: review?(martin.thomson) → review+
Comment on attachment 8632218 [details] MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt https://reviewboard.mozilla.org/r/13023/#review11653 ::: dom/media/MediaManager.cpp:1603 (Diff revision 1) > + nsPrincipal::GetOriginForURI(docURI, origin); Check return here. https://dxr.mozilla.org/mozilla-central/source/caps/nsPrincipal.cpp#100
Attachment #8632218 - Flags: review?(martin.thomson) → review+
Comment on attachment 8632219 [details] MozReview Request: Bug 1181428 - defer persisting until gUM succeeds or persistent permission https://reviewboard.mozilla.org/r/13025/#review11655 Ship It!
Attachment #8632219 - Flags: review?(martin.thomson) → review+
Comment on attachment 8632218 [details] MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt https://reviewboard.mozilla.org/r/13023/#review11677 Ship It!
Attachment #8632218 - Flags: review+
Attachment #8632218 - Flags: review+
Comment on attachment 8632217 [details] MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt
Attachment #8632217 - Attachment description: MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys → MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt
Attachment #8632217 - Flags: review+ → review?(martin.thomson)
Comment on attachment 8632218 [details] MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt Bug 1181428 - plumb origin through to success path. r=mt
Attachment #8632218 - Attachment description: MozReview Request: Bug 1181428 - plumb origin through to success path → MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt
Attachment #8632218 - Flags: review+ → review?(martin.thomson)
Attachment #8632219 - Flags: review+ → review?(martin.thomson)
Comment on attachment 8632219 [details] MozReview Request: Bug 1181428 - defer persisting until gUM succeeds or persistent permission Bug 1181428 - defer persisting until gUM succeeds or persistent permission
Comment on attachment 8632217 [details] MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt https://reviewboard.mozilla.org/r/13021/#review11681 Ship It!
Attachment #8632217 - Flags: review+
Attachment #8632217 - Flags: review?(martin.thomson)
Attachment #8632218 - Flags: review?(martin.thomson) → review+
Attachment #8632219 - Flags: review?(martin.thomson) → review+
Learned from RyanVM we don't do 4.0 android mochitests on production builds anymore, so off we go. Green enough try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ea1da5e87d9
Keywords: checkin-needed
Needs rebasing.
Keywords: checkin-needed
Comment on attachment 8632216 [details] MozReview Request: Bug 1181428 - move code to reuse test for active gum or persistent permission Bug 1181428 - move code to reuse test for active gum or persistent permission
Attachment #8632216 - Flags: review+ → review?(martin.thomson)
Comment on attachment 8632217 [details] MozReview Request: Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt Bug 1181428 - add persist option to OriginKey to skip saving of temporal keys. r=mt
Attachment #8632217 - Flags: review+ → review?(martin.thomson)
Comment on attachment 8632218 [details] MozReview Request: Bug 1181428 - plumb origin through to success path. r=mt Bug 1181428 - plumb origin through to success path. r=mt
Attachment #8632218 - Flags: review+ → review?(martin.thomson)
Comment on attachment 8632219 [details] MozReview Request: Bug 1181428 - defer persisting until gUM succeeds or persistent permission Bug 1181428 - defer persisting until gUM succeeds or persistent permission
Attachment #8632219 - Flags: review+ → review?(martin.thomson)
Attachment #8632216 - Flags: review?(martin.thomson) → review+
Attachment #8632217 - Flags: review?(martin.thomson) → review+
Attachment #8632218 - Flags: review?(martin.thomson) → review+
Attachment #8632219 - Flags: review?(martin.thomson) → review+
Rebased. Brought to you by Review Board. "The kinder gentler experience".
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: