|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0 Iceweasel/39.0 Build ID: 20150703100736 Steps to reproduce: 1. Open the New Tab page (either from Ctrl-T or typing about:newtab) 2. Press Ctrl-D Actual results: The "Page Bookmarked" dialog pops up, prompting the user to add the New Tab page as a bookmark Expected results: Nothing. Given that the bookmark star button is disabled on the New Tab page intentionally, one would expect that the New Tab page should not be able to be added as a bookmark via Ctrl-D.
Managed to reproduce this issue on Ubuntu 14.04 (x86), Mac OS X 10.10.4 and Windows 8.1 (x86), using: * 42.0a1 (2015-08-04) * 42.0a1 (2015-08-04) * 40.0 (20150804131237) * 38.2.0esr (20150803192212)
Created attachment 8745084 [details] MozReview Request: Bug 1181437 - Disable AddBookmarkAs command on non-bookmarkable pages Review commit: https://reviewboard.mozilla.org/r/48819/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48819/
Comment on attachment 8745084 [details] MozReview Request: Bug 1181437 - Disable AddBookmarkAs command on non-bookmarkable pages Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48819/diff/1-2/
Hi Matt, sorry for this, but I actually think this bug is a wontfix. It's a bit of time we discussed this behavior, basically when the star was part of the urlbar, it made sense to disable it when the urlbar value was invalid... But now that the star is a button apart, it refers to content, as such it may always be enabled. The fact one could bookmark about:blank or about:newtab, is a minor issue, not worth the effort, it's also as easy to remove the bookmark. bug 943888 is one of the bugs I found that relates to that choice, but I'm sure there are other bugs/comments around (just I can't find them atm). I think we should go towards simplification when the risk for the user is very limited or nonexistent, so in this case I'd go for removing this complex management of the star enabled/disabled status and leave it always enabled. IF you wish to work on bug 943888, you're clearly welcome to.
Comment on attachment 8745084 [details] MozReview Request: Bug 1181437 - Disable AddBookmarkAs command on non-bookmarkable pages https://reviewboard.mozilla.org/r/48819/#review45813