1181466 - [B2G][SMS][MMS] nsIDeletedMessageInfo object becomes empty in "sms-deleted" JS observers on KK.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Samael Wang [:freesamael] (away for now)]

The JS observe function in SmsService / MmsService didn't convert the subject through QueryInterface, which causes the object becomes empty on KK.

Comment 1

[Samael Wang [:freesamael] (away for now)]

Attachment: Fix observe function in SmsService/MmsService

Ensure deletedInfo object is converted by subject.QueryInterface()
when "sms-deleted" topic observed.

Comment 2

[Samael Wang [:freesamael] (away for now)]

Comment on attachment 8630966 [details] [diff] [review]
Fix observe function in SmsService/MmsService

Hi Bevis,

Could you help to review this patch?

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8630966 [details] [diff] [review]
Fix observe function in SmsService/MmsService

Review of attachment 8630966 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment addressed.

Thanks!

::: dom/mobilemessage/gonk/SmsService.js
@@ +1314,4 @@
>          }
>  
> +        if (deletedInfo && deletedInfo.deletedMessageIds) {
> +          for (let id of deletedInfo.deletedMessageIds) {

I think we could scan the queue as the first-level for-loop with deletedMessageIds.indexOf(this.queue[i].messageId) to check for better performance if massive deletion requested from App.
How do you think?
IMO, it should not be a normal case with massive messages in queue before sending.
Sorry for not being aware of this when reviewing the patch at first glance.

Comment 4

[Samael Wang [:freesamael] (away for now)]

Attachment: (v2) Fix observe function in SmsService/MmsService. r=btseng

Ensure deletedInfo object is converted by subject.QueryInterface()
when "sms-deleted" topic observed.

Comment 5

[Samael Wang [:freesamael] (away for now)]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b550ff9e4be9

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/746f6aab10ab

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/746f6aab10ab