1181467 - Can not copy/paste images to other applications

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Chiou [:boris]]

Cannot copy image from the browser into other applications on my MacOS and Ubuntu(gtk) based on current nightly build. (I think windows also has this problem.)

Reason:
We set kNativeImageMime type whiling copying image on the browser
(https://dxr.mozilla.org/mozilla-central/source/dom/base/nsCopySupport.cpp#452)
, but ContentParent::RecvSetClipboard() didn't handle this case correctly, so nsClipboard::SetData() cannot get the imgIContainer successfully on gtk/cocoa/qt...

Comment 1

[Boris Chiou [:boris]]

Attachment: Fix mime type checking while copying image

Handle kNativeImageMime case as other image types in RecvSetClipboard.

Comment 2

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3176646158f

Comment 3

[Boris Chiou [:boris]]

Note:
Most platforms treat the transferable data of kNativeImageMime as imgIContainer.
1. cocoa:
https://dxr.mozilla.org/mozilla-central/source/widget/cocoa/nsClipboard.mm#448
2. gtk:
https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsClipboard.cpp#177
3. windows:
https://dxr.mozilla.org/mozilla-central/source/widget/windows/nsClipboard.cpp#210
4. qt:
https://dxr.mozilla.org/mozilla-central/source/widget/qt/nsClipboard.cpp#155

KNativeImageMime is moz internal type, so it is easy to be neglected :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac484f13e854

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac484f13e854