1181504 - Remove MediaDecoderStateMachine::mAudioStartTime

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

AudioSink keeps the time of the first audio frame in mStartTime. By having AudioSink::AudioSink() return a time including mStartTime, we can remove MediaDecoderStateMachine::mAudioStartTime.

This bug also makes it easier to unify the behaviors of AudioSink and DecodedStream which are consumers of media data.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=015e72fc54f7

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1181504_part1_cleanup_mdsm_GetAudioClock-v1.patch

Ensure mAudioSink is non-null in MediaDecoderStateMachine::GetAudioClock().

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1181504_part2_remove_mAudioStartTime-v1.patch

Remove MediaDecoderStateMachine::mAudioStartTime.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8631377 [details] [diff] [review]
1181504_part2_remove_mAudioStartTime-v1.patch

Review of attachment 8631377 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/AudioSink.cpp
@@ -71,2 @@
>  {
> -  NS_ASSERTION(mStartTime != -1, "Should have audio start time by now");

Due to the recent refactoring of MDSM, start time is always 0 now. So audio start time is always >= 0.

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8631377 [details] [diff] [review]
1181504_part2_remove_mAudioStartTime-v1.patch

Review of attachment 8631377 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/AudioSink.cpp
@@ +72,2 @@
>  {
> +  //

Remove this.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee73c19e5a62
https://hg.mozilla.org/integration/mozilla-inbound/rev/1decb7ff8f34

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee73c19e5a62
https://hg.mozilla.org/mozilla-central/rev/1decb7ff8f34