Closed
Bug 1181553
Opened 9 years ago
Closed 9 years ago
Submit AsyncShutdown state information for TelemetrySend
Categories
(Toolkit :: Telemetry, defect, P2)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
(Whiteboard: [b5] [unifiedTelemetry] [uplift2])
Attachments
(2 files)
|
8.51 KB,
patch
|
Dexter
:
review+
Yoric
:
feedback+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
|
1.10 KB,
patch
|
Dexter
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In case of AsyncShutdown timeouts, we need to submit state information for TelemetrySend and its scheduler and send task, to diagnose issues.
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [b5] [unifiedTelemetry] [uplift2]
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8631088 -
Flags: review?(alessio.placitelli)
Attachment #8631088 -
Flags: feedback?(dteller)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8631090 -
Flags: review?(alessio.placitelli)
|
||
Updated•9 years ago
|
Attachment #8631090 -
Flags: review?(alessio.placitelli) → review+
|
|
||
Updated•9 years ago
|
Attachment #8631088 -
Flags: review?(alessio.placitelli) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Updated•9 years ago
|
Priority: -- → P2
Attachment #8631088 -
Flags: feedback?(dteller) → feedback+
https://hg.mozilla.org/integration/fx-team/rev/57c9ba3e414f https://hg.mozilla.org/integration/fx-team/rev/8b1537200acd
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57c9ba3e414f https://hg.mozilla.org/mozilla-central/rev/8b1537200acd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8631088 [details] [diff] [review] Submit AsyncShutdown state information for TelemetrySend Approval Request Comment [Feature/regressing bug #]: Unified Telemetry [User impact if declined]: This adds AsyncShutdown timeout information for diagnosis in case we see issues in the wild. [Describe test coverage new/current, TreeHerder]: Manually confirmed to be working, this just submits some state information. [Risks and why]: Low-risk, this only exposes some state information. [String/UUID change made/needed]: None.
Attachment #8631088 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8631090 [details] [diff] [review] Bonus: Remove unused member in TelemetrySend Approval Request Comment [Feature/regressing bug #]: Unified Telemetry [User impact if declined]: This is just a trivial removal of a redundant member, avoids rebasing and divergent history for future uplifts. [Describe test coverage new/current, TreeHerder]: Automated test-coverage. [Risks and why]: No risk, only a trivial removal. [String/UUID change made/needed]: None.
Attachment #8631090 -
Flags: approval-mozilla-aurora?
status-firefox41:
--- → affected
Comment on attachment 8631088 [details] [diff] [review] Submit AsyncShutdown state information for TelemetrySend More telemetry data is good. Patch has been in m-c for a while, should be safe to uplift to m-a.
Attachment #8631088 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8631090 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a48e6d9cc9d1 https://hg.mozilla.org/releases/mozilla-aurora/rev/0ce3d371a24d
You need to log in
before you can comment on or make changes to this bug.
Description
•