Closed Bug 1181553 Opened 10 years ago Closed 10 years ago

Submit AsyncShutdown state information for TelemetrySend

Categories

(Toolkit :: Telemetry, defect, P2)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [b5] [unifiedTelemetry] [uplift2])

Attachments

(2 files)

Submit AsyncShutdown state information for TelemetrySend
8.51 KB, patch
Dexter
: review+
Yoric
: feedback+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Bonus: Remove unused member in TelemetrySend
1.10 KB, patch
Dexter
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
In case of AsyncShutdown timeouts, we need to submit state information for TelemetrySend and its scheduler and send task, to diagnose issues.
Whiteboard: [b5] [unifiedTelemetry] [uplift2]
Attachment #8631088 - Flags: review?(alessio.placitelli)
Attachment #8631088 - Flags: feedback?(dteller)
Attachment #8631090 - Flags: review?(alessio.placitelli)
Attachment #8631090 - Flags: review?(alessio.placitelli) → review+
Attachment #8631088 - Flags: review?(alessio.placitelli) → review+
Keywords: checkin-needed
Priority: -- → P2
Attachment #8631088 - Flags: feedback?(dteller) → feedback+
https://hg.mozilla.org/mozilla-central/rev/57c9ba3e414f https://hg.mozilla.org/mozilla-central/rev/8b1537200acd
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8631088 [details] [diff] [review] Submit AsyncShutdown state information for TelemetrySend Approval Request Comment [Feature/regressing bug #]: Unified Telemetry [User impact if declined]: This adds AsyncShutdown timeout information for diagnosis in case we see issues in the wild. [Describe test coverage new/current, TreeHerder]: Manually confirmed to be working, this just submits some state information. [Risks and why]: Low-risk, this only exposes some state information. [String/UUID change made/needed]: None.
Attachment #8631088 - Flags: approval-mozilla-aurora?
Comment on attachment 8631090 [details] [diff] [review] Bonus: Remove unused member in TelemetrySend Approval Request Comment [Feature/regressing bug #]: Unified Telemetry [User impact if declined]: This is just a trivial removal of a redundant member, avoids rebasing and divergent history for future uplifts. [Describe test coverage new/current, TreeHerder]: Automated test-coverage. [Risks and why]: No risk, only a trivial removal. [String/UUID change made/needed]: None.
Attachment #8631090 - Flags: approval-mozilla-aurora?
Comment on attachment 8631088 [details] [diff] [review] Submit AsyncShutdown state information for TelemetrySend More telemetry data is good. Patch has been in m-c for a while, should be safe to uplift to m-a.
Attachment #8631088 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8631090 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Needs rebasing for Aurora uplift.
Flags: needinfo?(gfritzsche)
Bug 1156712 needs to land first.
Flags: needinfo?(gfritzsche)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: