Closed
Bug 1181581
Opened 10 years ago
Closed 10 years ago
[trivial] fix some typo in comments.
Categories
(Core :: JavaScript Engine: JIT, defect, P5)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: wuwei, Assigned: wuwei)
Details
Attachments
(1 file, 1 obsolete file)
|
4.54 KB,
patch
|
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
This is a trivial patch. It fixes a few typos in comments in js/src/jit/*.
Attachment #8631039 -
Flags: review?(luke)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8631039 [details] [diff] [review]
0001-bug-id-fix-some-typo-in-comments.patch
Review of attachment 8631039 [details] [diff] [review]:
-----------------------------------------------------------------
I think Luke is on PTO so stealing review.
Thanks for the patch! r=me with comment below addressed.
::: js/src/jit/Ion.cpp
@@ +1629,4 @@
> return false;
> }
>
> + // Passes after this point must not move instructions; these analyzes
|analyses| was correct here so please revert this one.
Attachment #8631039 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #1)
> Comment on attachment 8631039 [details] [diff] [review]
> 0001-bug-id-fix-some-typo-in-comments.patch
>
> Review of attachment 8631039 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I think Luke is on PTO so stealing review.
>
> Thanks for the patch! r=me with comment below addressed.
Thanks. :-)
>
> ::: js/src/jit/Ion.cpp
> @@ +1629,4 @@
> > return false;
> > }
> >
> > + // Passes after this point must not move instructions; these analyzes
>
> |analyses| was correct here so please revert this one.
Done.
Attachment #8631039 -
Attachment is obsolete: true
Attachment #8631083 -
Flags: checkin?
|
|
||
Comment 3•10 years ago
|
||
Not sure if sheriffs watch the checkin? flag so I'll add the checkin-needed keyword.
Assignee: nobody → lazyparser
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8631083 [details] [diff] [review]
Bug-1181581.patch
In the future, please just use the checkin-needed bug keyword. It works better with our automated bug marking tools.
Attachment #8631083 -
Flags: checkin? → checkin+
You need to log in
before you can comment on or make changes to this bug.
Description
•