1181587 - Update python-memcached to v1.53

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

python-memcached (Current: 1.48 Latest: 1.54 [wheel])

Comment 1

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ea0fbedf17fc663b41dc5ac219b9b509673ef91a
Bug 1181587 - Update python-memcached to v1.54

https://github.com/linsomniac/python-memcached/blob/master/ChangeLog
https://github.com/linsomniac/python-memcached/compare/8078ecfe...release-1.54

python-memcached now requires the package 'six', so that has to be
listed in common.txt and not just dev.txt.

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/27fed6557f190e2c3fd2a28dbdf5fd5719a7cb30
Revert ea0fbedf17 ("Bug 1181587 - Update python-memcached to v1.54")

To confirm whether this caused a response time regression for memcached
gets and sets.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0c53e1f68aae034a8008c718a904f1c04cbe81c6
Bug 1181587 - Update python-memcached to v1.53

https://github.com/linsomniac/python-memcached/blob/master/ChangeLog
https://github.com/linsomniac/python-memcached/compare/8078ecfe...release-1.53

python-memcached v1.54 has a performance regression, so only update to
v1.53 for now. See:
https://github.com/linsomniac/python-memcached/issues/71

Comment 4

[Ed Morley [:emorley]]

Numbers are stage get response times...

v1.53: ~3.8ms
e346892: ~3.9ms (changes: https://github.com/linsomniac/python-memcached/compare/release-1.53...e346892)
e268a8b: ~5.2ms (changes: https://github.com/linsomniac/python-memcached/compare/e346892...e268a8b)
918e88c: ~13ms (changes: https://github.com/linsomniac/python-memcached/compare/e268a8b...918e88c)

So looks like several of the Python 3 compatibility fixes regressed performance (at least on Python 2.7.8), but in particular:
https://github.com/linsomniac/python-memcached/commit/45403325e0249ff0f61d6ae449a7daeeb7e852e5

We can stay on 1.53 for now until it's resolved.

I'd also like to look at how pylibmc compares too, since we're already using it on Heroku.

Comment 5

[Ed Morley [:emorley]]

fwiw updating from 1.48 to 1.53 improved perf for gets by about 20% \o/