118159 - over-zealous scrollbar in outliner

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[:deanis74]

Steps to Reproduce:
1. Edit > Preferences
2. Expand Navigator
3. Expand Debug

Expected Results: list of categories fills visible outliner rows exactly, so no
scrollbar is required.

Actual Results: list of categories fills visible outliner rows exactly, but a
scrollbar appears with the thumb occupying the entire height of the scroll box.

Other Steps:
1. Edit > Preferences
2. Collapse Appearance
3. Expand Navigator
4. Expand Mail & Newsgroups

Expected Results: list of categories takes one row less than available visible
rows, so no scrollbar is displayed.

Actual Results: list of categories takes one row less than available visible
rows, but a scrollbar appears with the thumb occupying the entire height of the
scroll box.

BuildID: 2002010403 on Win2K

I see this in Manage Bookmarks as well, which points to an outliner problem.

I don't know if this is an old problem with outliner, or if it is related to
Jan's recent check-ins.

Comment 1

[:deanis74]

cc: hyatt and hewitt

Comment 2

[Morten Nilsen]

could this be related to my bug 117289?

Comment 3

[:deanis74]

I don't thihnk so.  When I click on the scrollbar in your testcase, it
disappears.  The scrollbar in the situation I described above is responsive, it
just doesn't move because it's as big as the encompassing scroll box.

Comment 4

[Jan Varga [:janv]]

This is probably only a polishing bug.
I noticed that when row count interferenced count of visible rows.

Comment 5

[Jan Varga [:janv]]

Attachment: fix

dean, could you r= ?

Comment 6

[:deanis74]

That looks like it will fix the first case where the categories occupy exactly
the number of visible rows, but what about the second case where there appears
to be an empty visible row?

Oh wait, looking at it closer I think the empty row isn't complete.  It's a few
pixels too short.  Should probably file a new bug on that sometime.

r=[e-mail]

Comment 7

[Blake Ross]

Comment on attachment 63514 [details] [diff] [review]
fix

sr=blake

Comment 8

[Jan Varga [:janv]]

fixed

Comment 9

[:deanis74]

verified with 2002010703 on Win2k