Windows Fx UI update issue - UnboundLocalError: local variable 'about_window' referenced before assignment

RESOLVED FIXED in Firefox 40


4 years ago
4 years ago


(Reporter: armenzg, Assigned: cmanchester)


Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed, firefox42 fixed)



(1 attachment)

We noticed this job running for 16 hours.
In the log I started seeing this:
23:43:07     INFO -  JavaScript error: chrome://marionette/content/marionette-server.js, line 3531: TypeError: this.listener is null
23:45:05     INFO -   4:33.10 TEST_END: MainThread ERROR, expected PASS
23:45:05     INFO -  Traceback (most recent call last):
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\marionette\", line 296, in run
23:45:05     INFO -      testMethod()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_tests\update\fallback\", line 28, in test_update
23:45:05     INFO -      self._test_update()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_tests\update\fallback\", line 22, in _test_update
23:45:05     INFO -      self.download_and_apply_forced_update()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_harness\testcases\", line 188, in download_and_apply_forced_update
23:45:05     INFO -      self.updates[self.current_update_index]['patch'] = about_window.patch_info
23:45:05     INFO -  UnboundLocalError: local variable 'about_window' referenced before assignment
Posted file PR With fix
Attachment #8631176 - Flags: review?(armenzg)
Assignee: nobody → cmanchester
Attachment #8631176 - Flags: review?(armenzg) → review+
Closed: 4 years ago
Resolution: --- → FIXED
Version: Version 3 → Firefox 42
I didn't land on all the branches, I'll do that now.
Blocks: 1182796
Chris, thanks for the fix! Do you know if there is a bug open for Marionette to kill the testrun? This behavior sounds crazy that no hard-kill is invoked for 16h! :(
Flags: needinfo?(cmanchester)
Target Milestone: --- → Firefox 42
Version: Firefox 42 → unspecified
I'm not sure what's causing the long run, but I would expect mozharness or buildbot to intervene at some point even if the runner got completely stuck.
Flags: needinfo?(cmanchester)
Hm, maybe Armen as reporter might be able to shed some more light on it.
Flags: needinfo?(armenzg)
But anyway, I see that as a problem in Marionette too, which needs to be fixed.
What chamenchester mentions. There is nothing here for us.
Flags: needinfo?(armenzg)
No longer depends on: 1148546
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.