1181682 - Windows Fx UI update issue - UnboundLocalError: local variable 'about_window' referenced before assignment

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Armen [:armenzg]]

We noticed this job running for 16 hours.
In the log I started seeing this:
23:43:07     INFO -  JavaScript error: chrome://marionette/content/marionette-server.js, line 3531: TypeError: this.listener is null
23:45:05     INFO -   4:33.10 TEST_END: MainThread ERROR, expected PASS
23:45:05     INFO -  Traceback (most recent call last):
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\marionette\marionette_test.py", line 296, in run
23:45:05     INFO -      testMethod()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_tests\update\fallback\test_fallback_update.py", line 28, in test_update
23:45:05     INFO -      self._test_update()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_tests\update\fallback\test_fallback_update.py", line 22, in _test_update
23:45:05     INFO -      self.download_and_apply_forced_update()
23:45:05     INFO -    File "c:\builds\moz2_slave\rel-m-beta-w32_beta_u_t_6-0000\build\venv\lib\site-packages\firefox_ui_harness\testcases\update.py", line 188, in download_and_apply_forced_update
23:45:05     INFO -      self.updates[self.current_update_index]['patch'] = about_window.patch_info
23:45:05     INFO -  UnboundLocalError: local variable 'about_window' referenced before assignment

https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/40.0b2-candidates/build1/logs/release-mozilla-beta-win32_beta_update_tests_6-bm82-build1-build3.txt.gz

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: PR With fix

Comment 2

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/2339aacd9f6c8f8bd3c2560aba39f87352a20441

Comment 3

[[e-mail] (:bhearsum)]

Did this fix make it into the 40.0b3 tests? http://buildbot-master85.bb.releng.scl3.mozilla.com:8001/builders/release-mozilla-beta-win64_ui_update_verify_beta_6%2F6/builds/2/steps/run_script/logs/stdio is still showing the problem.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I didn't land on all the branches, I'll do that now.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/c41441f8cb021e15d598fab820031003ac0211d7
https://github.com/mozilla/firefox-ui-tests/commit/587357d52a245ba11324cf95313aa69bc12f143a

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Chris, thanks for the fix! Do you know if there is a bug open for Marionette to kill the testrun? This behavior sounds crazy that no hard-kill is invoked for 16h! :(

Comment 7

[Chris Manchester (limited bugmail, email directly)]

I'm not sure what's causing the long run, but I would expect mozharness or buildbot to intervene at some point even if the runner got completely stuck.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hm, maybe Armen as reporter might be able to shed some more light on it.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

But anyway, I see that as a problem in Marionette too, which needs to be fixed.

Comment 10

[Armen [:armenzg]]

What chamenchester mentions. There is nothing here for us.