1181825 - Enable eslint rules for Loop: no-extra-boolean cast, no-redeclare

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Enable some more eslint rules for Loop. Rules to enable in this bug:

no-extra-boolean-cast - disallow double-negation boolean casts in a boolean context
no-redeclare - disallow declaring the same variable more than once

Both of these rules can be enabled by delete the relevant lines in  browser/components/loop/.eslintrc.

Then you can run eslint in the browser/components/loop directory with:

  eslint  --ext .js --ext .jsm --ext .jsx .

The errors listed in the output are to be fixed.

If there's errors in a .jsx file that is affected: fix the file and run the react tools to generate the .js file (https://wiki.mozilla.org/Loop/Development#Developing).

If you need more help setting up eslint, see https://wiki.mozilla.org/Loop/Development#Additional_Requirements

Information about the eslint rules can be found here:

http://eslint.org/docs/rules/

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Bug1181825.patch

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8636484 [details] [diff] [review]
Bug1181825.patch

Review of attachment 8636484 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great; thanks for the patch!

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Enable eslint rules for Loop: no-extra-boolean cast, no-redeclare

Patch rebased against current fx-team

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6940314afe11

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Thanks for the patch.  It's exciting to see our infrastructure keep improving so we can write code more effectively!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6940314afe11