Closed Bug 1181896 Opened 5 years ago Closed 5 years ago

Change gUM() NotFoundError to OverconstrainedError for constraint-failures

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- affected
firefox43 --- fixed
Blocking Flags:

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(2 files)

Right now, getUserMedia(impossibleConstraints) fails with NotFoundError.

Per https://github.com/w3c/mediacapture-main/pull/213 and #194 it should fail with OverconstrainedError, with an error.constraintName attribute containing the name of one of the offending constraints.
backlog: --- → webRTC+
Rank: 35
Bug 1181896 - rename .constraintName to .constraint in MediaStreamError
Attachment #8663073 - Flags: review?(rjesup)
Attachment #8663073 - Flags: review?(bzbarsky)
Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.
Attachment #8663074 - Flags: review?(rjesup)
Assignee: nobody → jib
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17731

r=me
Attachment #8663073 - Flags: review?(bzbarsky) → review+
Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

https://reviewboard.mozilla.org/r/19703/#review17739

::: dom/media/MediaManager.cpp:1001
(Diff revision 1)
> +    // requires updating as new constraints are added!

Put a pointer to this code in whatever file defines constraints (webidl probably) so that people remember to update this when new constraints are added.
Attachment #8663074 - Flags: review?(rjesup) → review+
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17741
Attachment #8663073 - Flags: review?(rjesup) → review+
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Bug 1181896 - rename .constraintName to .constraint in MediaStreamError
Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.
Any chance someone could land this before merge?
Flags: needinfo?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/d03c69e05eed
https://hg.mozilla.org/mozilla-central/rev/4013ca84d244
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.