1181896 - Change gUM() NotFoundError to OverconstrainedError for constraint-failures

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Right now, getUserMedia(impossibleConstraints) fails with NotFoundError.

Per https://github.com/w3c/mediacapture-main/pull/213 and #194 it should fail with OverconstrainedError, with an error.constraintName attribute containing the name of one of the offending constraints.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17731

r=me

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

https://reviewboard.mozilla.org/r/19703/#review17739

::: dom/media/MediaManager.cpp:1001
(Diff revision 1)
> +    // requires updating as new constraints are added!

Put a pointer to this code in whatever file defines constraints (webidl probably) so that people remember to update this when new constraints are added.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17741

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Any chance someone could land this before merge?

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d03c69e05eed
https://hg.mozilla.org/integration/mozilla-inbound/rev/4013ca84d244

Comment 10

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/d03c69e05eed
https://hg.mozilla.org/mozilla-central/rev/4013ca84d244