Change gUM() NotFoundError to OverconstrainedError for constraint-failures

RESOLVED FIXED in Firefox 43

Status

()

Core
WebRTC: Audio/Video
P3
normal
Rank:
35
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jib, Assigned: jib)

Tracking

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Right now, getUserMedia(impossibleConstraints) fails with NotFoundError.

Per https://github.com/w3c/mediacapture-main/pull/213 and #194 it should fail with OverconstrainedError, with an error.constraintName attribute containing the name of one of the offending constraints.
backlog: --- → webRTC+
Rank: 35
Blocks: 912342
Created attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Bug 1181896 - rename .constraintName to .constraint in MediaStreamError
Attachment #8663073 - Flags: review?(rjesup)
Attachment #8663073 - Flags: review?(bzbarsky)
Created attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.
Attachment #8663074 - Flags: review?(rjesup)
Assignee: nobody → jib
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17731

r=me
Attachment #8663073 - Flags: review?(bzbarsky) → review+
Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

https://reviewboard.mozilla.org/r/19703/#review17739

::: dom/media/MediaManager.cpp:1001
(Diff revision 1)
> +    // requires updating as new constraints are added!

Put a pointer to this code in whatever file defines constraints (webidl probably) so that people remember to update this when new constraints are added.
Attachment #8663074 - Flags: review?(rjesup) → review+
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

https://reviewboard.mozilla.org/r/19701/#review17741
Attachment #8663073 - Flags: review?(rjesup) → review+
Comment on attachment 8663073 [details]
MozReview Request: Bug 1181896 - rename .constraintName to .constraint in MediaStreamError

Bug 1181896 - rename .constraintName to .constraint in MediaStreamError
Comment on attachment 8663074 [details]
MozReview Request: Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.

Bug 1181896 - make gUM fail w/OverconstrainedError and candidate argument.
Keywords: checkin-needed
Any chance someone could land this before merge?
Flags: needinfo?(rjesup)
Blocks: 1195951

Comment 9

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d03c69e05eed
https://hg.mozilla.org/integration/mozilla-inbound/rev/4013ca84d244
Keywords: checkin-needed

Comment 10

2 years ago
https://hg.mozilla.org/mozilla-central/rev/d03c69e05eed
https://hg.mozilla.org/mozilla-central/rev/4013ca84d244
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

Updated

2 years ago
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.