1182066 - DefaultLoadFlags are not set for the first and some other requests

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Dragana Damjanovic [:dragana]]

As described in nsIDocShell:
"
  /*
   * Default load flags (as defined in nsIRequest) that will be set on all
   * requests made by this docShell and propagated to all child docShells and
   * to nsILoadGroup::defaultLoadFlags for the docShell's loadGroup.
   * Default is no flags.  Once set, only future requests initiated by the
   * docShell are affected, so in general, these flags should be set before
   * the docShell loads any content.
  */
  attribute nsLoadFlags defaultLoadFlags;
"

and LoadGroup
"
/**
 * The set of load flags that will be added to all new requests added to
 * this group. Any existing requests in the load group are not modified,
 * so it is expected these flags will be added before requests are added
 * to the group - typically via nsIDocShell::defaultLoadFlags on a new
 * docShell.
 * Note that these flags are *not* added to the default request for the
 * load group; it is expected the default request will already have these
 * flags (again, courtesy of setting nsIDocShell::defaultLoadFlags before
 * the docShell has created the default request.)
 */
 attribute nsLoadFlags defaultLoadFlags;

"

It is expected that the first request, that will become the default request, already has this flags -
It is expected but not guaranteed.

The default request is sometime deleted if docLoader is not busy
http://mxr.mozilla.org/mozilla-central/source/uriloader/base/nsDocLoader.cpp#707
and for the next coming request default flags will not be enforced as well.

I am not sure of the design here, adding a patch to enforce defaultLoadFlags for each request

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: defaultLoadFlags_v1.patch

Reading the description of this parameter, this fix looks logical.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8631581 [details] [diff] [review]
defaultLoadFlags_v1.patch

Review of attachment 8631581 [details] [diff] [review]:
-----------------------------------------------------------------

bingo! nicely done.

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: defaultLoadFlags_v1.patch

just fixed some tests.

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e92a244475

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a073bb6c768

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a073bb6c768