1182093 - [Aries] file_manager.remove doesn't return an object with an attribute called 'name'

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

So we get errors like:

> AttributeError: 'dict' object has no attribute 'name'
> 
> Traceback (most recent call last):
>   File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/.env/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 277, in run
>    self.setUp()
>  File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sdcard.py", line 12, in setUp
>    self.device.file_manager.remove(file.name)

To fix that, ee need to take a look here: ttps://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/file_manager.py#L109

Comment 1

[Johan Lorenzo [:jlorenzo]]

It turns out that this test pass on the latest build[1]. We can't have a correct build with Jenkins today. It fails to download the pip dependencies.

John, could you tell me if the test also passes on your Aries? If so, let's close this bug as Works for me.

[1] Build ID               20150825021113
Gaia Revision          b441bde54293bea5254dc340845effe951fa3906
Gaia Date              2015-08-24 17:47:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/04b8c412d9f58fb6194c58dcaa66bf278bbd53cf
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150825.013149
Firmware Date          Tue Aug 25 01:31:57 UTC 2015
Bootloader             s1

Comment 2

[John Dorlus [:Silne30]]

This works on my Aries.