1182129 - [PP] Back out privacy panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dave Huseby [:huseby]]

The time has come to back out the privacy panel.  The plan is as follows:

* Remove the privacy panel.
* Clean up the geolocation changes, remove fuzzing, make no location, fixed location and accurate location permanent in gecko see Bug 1097229.
* Maybe move the RPP out into its own app.
* Merge the privacy coaching material into the existing privacy coach project and/or the FTU experience on FxOS.
* Maybe merge the app permission panels with Freddy's existing verbose permissions panel.

Comment 1

[Dave Huseby [:huseby]]

Attachment: this patch completely backs out the privacy panel.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8632004 [details] [review]
this patch completely backs out the privacy panel.

Redirecting to a Settings peer since the only part of the patch which isn't an |rm| is there :)

Comment 3

[[e-mail]]

@Dave could you provide more insight, discussion link, or agreement with PM so I can get some context about why we will do this?

Comment 4

[[e-mail]]

Comment on attachment 8632004 [details] [review]
this patch completely backs out the privacy panel.

The removal generally looks good to me, but please address above comment and set review again. Since there is a portion of verticalhome, please also include verticalhome peer in review chain.

Comment 5

[[e-mail]]

Thanks Paul and Wilfred to provide more information. It makes more sense then have a stand alone privacy control panel.

@Dave the PR has some conflict, please fix that and set review again to me & verticalhome peer. Thanks.

Comment 6

[Dave Huseby [:huseby]]

Alright, I just rebased.

Comment 7

[Dave Huseby [:huseby]]

Attachment: rebased patch to back out privacy panel

rebased to HEAD

Comment 8

[[e-mail]]

Comment on attachment 8638192 [details] [review]
rebased patch to back out privacy panel

Test on device and the panel is removed

Comment 9

[[e-mail]]

Since there's some discussion about privacy control's related test regression,

@huseby could you rebase and merge the commit (and make sure treeherder green) soon?

Comment 10

[Dave Huseby [:huseby]]

Yup.

Comment 11

[[e-mail]]

How's going with this issue? Dave do you still work on this?

Comment 12

[Dave Huseby [:huseby]]

I got stuck on fixing the failing unit tests.  Never figured out how to run Mullet on Linux.  I had other more high priority fixes to make.  I have time now to look at this again.  Is there a better way to run the unit tests to fix them?

Comment 13

[[e-mail]]

As I know we use node 0.10 with npm2 for test, you could use 'nvm' to manage different versions of node and manually update to npm2.
Someone also report node 0.12 works well though

Comment 14

[[e-mail]]

Attachment: pull request redirect to github

pull Dave's PR and fixing tests

Comment 15

[[e-mail]]

I think the main reason is the patch miss deleted `shared/test/unit/mocks/mock_manifest_helper.js`, so it broken other tests that used that test mock.

Comment 16

[[e-mail]]

treeherder all green and on device test looks fine. merged to master https://github.com/mozilla-b2g/gaia/commit/87f5c9d55ab6a77dcfa48a3f3a8b4f5016f3c657

Comment 17

[Martijn Wargers (dead)]

Should this be removed as well?
http://mxr.mozilla.org/gaia/source/apps/settings/locales/settings.en-US.properties#1580
1580 privacySection.ariaLabel=Privacy Controls

Comment 18

[[e-mail]]

thanks for catching it,

fixed with
https://github.com/mozilla-b2g/gaia/commit/4b47f62e10f0901f2c37f2268026fd828a26b7d5

thanks!

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This is a shame we did this because:
1) there was a way to change the geolocation location ; this hurts our testing for geolocation.
2) The privacy panel was only in the engineering build and was not in production

I would prefer to have it back please.

Comment 20

[Dave Huseby [:huseby]]

we can add back a way to set the geolocation location.  the rest of it needs to be refactored and merged back in if appropriate.  this was backed out because it was largely broken and unmaintained code.