1182160 - enable vertical writing-mode sections of tests for logical properties in UA stylesheets

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Kew [:jfkthame]]

Some of the tests from bug 1119475 have their vertical writing-mode sections commented out, because the elements concerned were not yet fully vertical-enabled when the tests were landed. This concerned <input type=number> and <table>.

Now that we have vertical support for these elements, we should enable those parts of the testcases.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: part 1 - Enable vertical writing-mode portion of ua-style-sheet-input-number testcase

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: part 2 - Enable vertical writing-mode portion of ua-style-sheet-* tests involving tables

These are the cases that involved tables; on inspection, it looks like the references for -9 and -10 are wrong, so in addition to uncommenting, I've fixed those files.

Comment 3

[Jonathan Kew [:jfkthame]]

Try run with these patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8c9798c7c82.

Comment 4

[Cameron McCormack (:heycam)]

I must say it's a little confusing that <caption align=right> when the caption is display:block ends up left-aligning the caption to the table!  But I can see that falls out of the UA style rules.

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Cameron McCormack (:heycam) from comment #4)
> I must say it's a little confusing that <caption align=right> when the
> caption is display:block ends up left-aligning the caption to the table! 
> But I can see that falls out of the UA style rules.

That bothered me, too, when we first landed these tests; but I concluded it was the expected (if rather unexpected) behavior. ;)

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/247ec16f27e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/3596d7aed0de

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/247ec16f27e0
https://hg.mozilla.org/mozilla-central/rev/3596d7aed0de