1182274 - Browser UI not updated after DOM pushState/popState with back/forward

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Go to https://people.mozilla.org/~bnicholson/test/pushstate.html.
2) Push the button on the page twice.
3) Push back twice.
4) Push forward twice.

After these steps, the page URL should change (to include #foobar), and the forward button should be disabled. Neither happen until the phone is rotated.

This seems to be related to the built-in back/forward list: pages that use pushState don't fire the typical navigation events we rely on to update the UI. We need to figure out some other way to detect this.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/700

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8631899 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/700

This looks good to me. Are there UI tests to test the areas that are affected? Navigation, Reading View?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Stefan Arentz [:st3fan] from comment #2)
> Comment on attachment 8631899 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/700
> 
> This looks good to me. Are there UI tests to test the areas that are
> affected? Navigation, Reading View?

Not really -- those are still in the works. I hit a number of other URL bar regressions while writing them, so trying to clear those out first.

Comment 4

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/1bfbbeefb04ec55d0ceb04fd37ee4b2f7b4cbf12