Update source-map lib to fix bug in SourceMapConsumer.fromSourceMap

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 42
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed, firefox42 fixed)

Details

Attachments

(1 attachment)

See https://github.com/mozilla/source-map/pull/193

Luckily, our code doesn't actually trigger this behavior, but perhaps some addon that uses the tree's source-map lib does.
Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

Asking for a quick rubber stamp. These are the two PRs you just reviewed for the mozilla/source-map library.
Attachment #8633132 - Flags: review?(jlong)
Attachment #8633132 - Flags: review?(jlong) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/262d05bd5d3c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
No longer blocks: 1166048
Depends on: 1166048
Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

Approval Request Comment
[Feature/regressing bug #]: Bug 1166048
[User impact if declined]: Minimal, possibly broken addons.
[Describe test coverage new/current, TreeHerder]: Two new test cases for the regressions.
[Risks and why]: Bug 1166048 fixed some bugs but then some npm modules that also use the source-map lib found regressions. AFAICT, we don't ever trigger those regressions in the library, but this patch fixes them anyhow.
[String/UUID change made/needed]: None
Attachment #8633132 - Flags: approval-mozilla-beta?
Attachment #8633132 - Flags: approval-mozilla-aurora?
Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

New upstream version, has good test coverage, taking it to aurora.
Attachment #8633132 - Flags: approval-mozilla-beta?
Attachment #8633132 - Flags: approval-mozilla-beta+
Attachment #8633132 - Flags: approval-mozilla-aurora?
Attachment #8633132 - Flags: approval-mozilla-aurora+
a+ is enough for the uplift!
Keywords: checkin-needed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.