1182278 - Update source-map lib to fix bug in SourceMapConsumer.fromSourceMap

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

See https://github.com/mozilla/source-map/pull/193

Luckily, our code doesn't actually trigger this behavior, but perhaps some addon that uses the tree's source-map lib does.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Update the tree's copy of the mozilla/source-map library to 0.4.4

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

Asking for a quick rubber stamp. These are the two PRs you just reviewed for the mozilla/source-map library.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=993123f10680

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/262d05bd5d3c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/262d05bd5d3c

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

Approval Request Comment
[Feature/regressing bug #]: Bug 1166048
[User impact if declined]: Minimal, possibly broken addons.
[Describe test coverage new/current, TreeHerder]: Two new test cases for the regressions.
[Risks and why]: Bug 1166048 fixed some bugs but then some npm modules that also use the source-map lib found regressions. AFAICT, we don't ever trigger those regressions in the library, but this patch fixes them anyhow.
[String/UUID change made/needed]: None

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8633132 [details] [diff] [review]
Update the tree's copy of the mozilla/source-map library to 0.4.4

New upstream version, has good test coverage, taking it to aurora.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

a+ is enough for the uplift!

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8e64dbdbaea5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/14009d28adc1