Closed
Bug 1182278
Opened 9 years ago
Closed 9 years ago
Update source-map lib to fix bug in SourceMapConsumer.fromSourceMap
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox40 fixed, firefox41 fixed, firefox42 fixed)
RESOLVED
FIXED
Firefox 42
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
16.61 KB,
patch
|
jlong
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
See https://github.com/mozilla/source-map/pull/193 Luckily, our code doesn't actually trigger this behavior, but perhaps some addon that uses the tree's source-map lib does.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8633132 [details] [diff] [review] Update the tree's copy of the mozilla/source-map library to 0.4.4 Asking for a quick rubber stamp. These are the two PRs you just reviewed for the mozilla/source-map library.
Attachment #8633132 -
Flags: review?(jlong)
Assignee | ||
Comment 3•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=993123f10680
Updated•9 years ago
|
Attachment #8633132 -
Flags: review?(jlong) → review+
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/262d05bd5d3c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8633132 [details] [diff] [review] Update the tree's copy of the mozilla/source-map library to 0.4.4 Approval Request Comment [Feature/regressing bug #]: Bug 1166048 [User impact if declined]: Minimal, possibly broken addons. [Describe test coverage new/current, TreeHerder]: Two new test cases for the regressions. [Risks and why]: Bug 1166048 fixed some bugs but then some npm modules that also use the source-map lib found regressions. AFAICT, we don't ever trigger those regressions in the library, but this patch fixes them anyhow. [String/UUID change made/needed]: None
Attachment #8633132 -
Flags: approval-mozilla-beta?
Attachment #8633132 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8633132 [details] [diff] [review] Update the tree's copy of the mozilla/source-map library to 0.4.4 New upstream version, has good test coverage, taking it to aurora.
Attachment #8633132 -
Flags: approval-mozilla-beta?
Attachment #8633132 -
Flags: approval-mozilla-beta+
Attachment #8633132 -
Flags: approval-mozilla-aurora?
Attachment #8633132 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
status-firefox40:
--- → affected
status-firefox41:
--- → affected
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/14009d28adc1
Flags: in-testsuite+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•