1182301 - Better/more configurable notifications from mach

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[u408661]

Attachment: better-mach-notifications.patch

I have often found myself wishing that (1) I could make mach notify me earlier than the default 5 minutes, and (2) mach's notification would tell me if the build failed (rather than just "completed"). So, I whipped up a patch to make it do those things.

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 8631828 [details] [diff] [review]
better-mach-notifications.patch

Review of attachment 8631828 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +424,5 @@
>  
> +        notify_minimum_time = 300
> +        try:
> +            notify_minimum_time = int(os.getenv('MACH_NOTIFY_MINTIME'))
> +        except (TypeError, ValueError):

Why TypeError?

Also, os.environ is preferred over os.getenv(). e.g. os.environ.get('MACH_NOTIFY_MINTIME', '300')

Comment 2

[u408661]

(In reply to Gregory Szorc [:gps] from comment #1)
> Comment on attachment 8631828 [details] [diff] [review]
> better-mach-notifications.patch
> 
> Review of attachment 8631828 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: python/mozbuild/mozbuild/mach_commands.py
> @@ +424,5 @@
> >  
> > +        notify_minimum_time = 300
> > +        try:
> > +            notify_minimum_time = int(os.getenv('MACH_NOTIFY_MINTIME'))
> > +        except (TypeError, ValueError):
> 
> Why TypeError?

Without a default (as in the patch), os.getenv returns None, which causes int() to raise a TypeError instead of a ValueError.

> Also, os.environ is preferred over os.getenv(). e.g.
> os.environ.get('MACH_NOTIFY_MINTIME', '300')

This makes the TypeError check useless, though :)

Comment 3

[Gregory Szorc [:gps]]

notify_minimum_time = 300
try:
    notify_minimum_time = int(os.environ.get('MACH_NOTIFY_MINTIME', '300'))
except ValueError:
    pass

Comment 4

[u408661]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d10aa8e7b3d7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d10aa8e7b3d7