1182318 - Remove |Closure| from CycleCollectedRuntime.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

In bug 1181445 comment 20, mccr8 said:

> >    // NB: This is here just to preserve the existing XPConnect order. I doubt it
> >    // would hurt to do this after the JS holders.
> >    TraverseAdditionalNativeRoots(aCb);
> >  
> >    Closure closure(&aCb);
> 
> This closure can be disentangled more [...] In short: closure.mCb is aCb and
> the closure for TraceCallbackFunc can just become bool*. I just mashed
> together two different closures for convenience.

Comment 1

[Andrew McCreight [:mccr8]]

I can do this after the other bug lands and merges over.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove Closure::mCb.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Remove Closure from CycleCollectedJSRuntime.

Closure is now just a wrapper around a single boolean, so instead pass a pointer to the boolean.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for the fast reviews.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec877b5c90ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/b397fee6cd67

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec877b5c90ff
https://hg.mozilla.org/mozilla-central/rev/b397fee6cd67